Repository navigation
Commit af021d2
fix(workflows): init step must not replace init's own error with "SystemExit: 1" (#4530)
`InitStep._run_init` appended the runner's exception to stderr:
if result.exit_code != 0 and result.exception is not None:
detail = f"{type(result.exception).__name__}: {result.exception}"
stderr = f"{stderr}\n{detail}".strip() if stderr else detail
That branch is written for an unexpected crash, but `typer.Exit(n)` -- how
`specify init` reports every ordinary failure -- surfaces through `CliRunner`
as `result.exception = SystemExit(n)`, so it fired on routine errors too.
`init` prints its diagnostics through Rich to stdout, so `result.stderr` is
empty and the synthesized detail became the ENTIRE stderr, preempting
`execute`'s fallback:
error=(stderr.strip() or stdout.strip() or f"specify init exited ...")
`stdout.strip()` -- which holds the real message -- was never reached.
Reproduced on main with an ordinary typo in `integration:` (which
`InitStep.validate` does not value-check):
validate : []
status : failed | exit_code: 1
result.error : 'SystemExit: 1'
output.stderr: 'SystemExit: 1'
stdout holds : "... lingma, muse, omp, opencode, pi, qodercli, qwen,
rovodev, shai, tabnine, trae, vibe, zcode, zed"
Now excludes only `SystemExit`, so an ordinary non-zero exit falls through to
init's own output while a genuine crash still reports its exception.
Rebased onto current main (files moved in the workflow/bundler restructure).
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>1 parent 2dda047 commit af021d2
2 files changed
Lines changed: 100 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
298 | | - | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
299 | 313 | | |
300 | 314 | | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
301 | 326 | | |
302 | 327 | | |
303 | 328 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3150 | 3150 | | |
3151 | 3151 | | |
3152 | 3152 | | |
| 3153 | + | |
| 3154 | + | |
| 3155 | + | |
| 3156 | + | |
| 3157 | + | |
| 3158 | + | |
| 3159 | + | |
| 3160 | + | |
| 3161 | + | |
| 3162 | + | |
| 3163 | + | |
| 3164 | + | |
| 3165 | + | |
| 3166 | + | |
| 3167 | + | |
| 3168 | + | |
| 3169 | + | |
| 3170 | + | |
| 3171 | + | |
| 3172 | + | |
| 3173 | + | |
| 3174 | + | |
| 3175 | + | |
| 3176 | + | |
| 3177 | + | |
| 3178 | + | |
| 3179 | + | |
| 3180 | + | |
| 3181 | + | |
| 3182 | + | |
| 3183 | + | |
| 3184 | + | |
| 3185 | + | |
| 3186 | + | |
| 3187 | + | |
| 3188 | + | |
| 3189 | + | |
| 3190 | + | |
| 3191 | + | |
| 3192 | + | |
| 3193 | + | |
| 3194 | + | |
| 3195 | + | |
| 3196 | + | |
| 3197 | + | |
| 3198 | + | |
| 3199 | + | |
| 3200 | + | |
| 3201 | + | |
| 3202 | + | |
| 3203 | + | |
| 3204 | + | |
| 3205 | + | |
| 3206 | + | |
| 3207 | + | |
| 3208 | + | |
| 3209 | + | |
| 3210 | + | |
| 3211 | + | |
| 3212 | + | |
| 3213 | + | |
| 3214 | + | |
| 3215 | + | |
| 3216 | + | |
| 3217 | + | |
| 3218 | + | |
| 3219 | + | |
| 3220 | + | |
| 3221 | + | |
| 3222 | + | |
| 3223 | + | |
| 3224 | + | |
| 3225 | + | |
| 3226 | + | |
3153 | 3227 | | |
3154 | 3228 | | |
3155 | 3229 | | |
| |||
0 commit comments