fix(integrations): use strip() only to test blankness, return the value verbatim

Address review feedback: normalizing with strip() changed EXISTING valid values,
contrary to this PR's "no behaviour change for valid usage" claim -- a quoted
`--commands-dir ' commands '` previously targeted the literal ` commands `
directory and would have started writing to `commands` instead.

The blankness test still uses strip(), but the accepted value is now returned
unchanged, so the fix stays limited to empty/blank input. Test updated
accordingly: a padded non-blank value must round-trip verbatim (quoted in
raw_options, since shlex.split() consumes unquoted padding before this code
sees it).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: jawwad-ali

src/specify_cli/integrations/generic/__init__.py

@@ -53,16 +53,16 @@ def _resolve_commands_dir(
         """
         parsed_options = parsed_options or {}
 
-        # Accept a value only when it is non-BLANK, and normalize the padding.
-        # An empty value resolves to the project root (``project_root / ""``),
-        # and a whitespace-only one to a directory literally named " ", so
-        # either would silently scatter command files instead of failing with
-        # the documented "required" error. Both branches below apply the same
-        # rule so they cannot drift apart.
+        # Accept a value only when it is non-BLANK. An empty value resolves to
+        # the project root (``project_root / ""``) and a whitespace-only one to
+        # a directory literally named " ", so either would silently scatter
+        # command files instead of failing with the documented "required"
+        # error. ``strip()`` is used ONLY to decide blankness -- the value
+        # itself is returned verbatim, so a deliberate (if unusual) padded
+        # directory name still targets exactly what the user asked for. Both
+        # branches below apply the same rule so they cannot drift apart.
         commands_dir = parsed_options.get("commands_dir")
-        if isinstance(commands_dir, str):
-            commands_dir = commands_dir.strip()
-        if commands_dir:
+        if commands_dir and (not isinstance(commands_dir, str) or commands_dir.strip()):
             return commands_dir
 
         # Fall back to raw_options (--integration-options="--commands-dir ...")
@@ -72,12 +72,12 @@ def _resolve_commands_dir(
             tokens = shlex.split(raw)
             for i, token in enumerate(tokens):
                 if token == "--commands-dir" and i + 1 < len(tokens):
-                    candidate = tokens[i + 1].strip()
-                    if candidate:
+                    candidate = tokens[i + 1]
+                    if candidate.strip():
                         return candidate
                 if token.startswith("--commands-dir="):
-                    candidate = token.split("=", 1)[1].strip()
-                    if candidate:
+                    candidate = token.split("=", 1)[1]
+                    if candidate.strip():
                         return candidate
 
         raise ValueError(

tests/integrations/test_integration_generic.py

@@ -75,13 +75,20 @@ def test_resolve_commands_dir_rejects_blank_raw_value(self, raw):
             GenericIntegration._resolve_commands_dir({}, {"raw_options": raw})
 
     @pytest.mark.parametrize("padded", ["  .myagent/cmds  ", "\t.myagent/cmds"])
-    def test_resolve_commands_dir_strips_padding(self, padded):
-        """A padded but real value is normalized rather than rejected."""
+    def test_resolve_commands_dir_returns_padded_value_verbatim(self, padded):
+        """A padded but non-blank value is accepted and returned UNCHANGED: the
+        blankness test uses strip(), but rewriting the value would silently
+        retarget a directory the user asked for by name."""
         from specify_cli.integrations.generic import GenericIntegration
 
         assert GenericIntegration._resolve_commands_dir(
             {"commands_dir": padded}, {}
-        ) == ".myagent/cmds"
+        ) == padded
+        # Quoted in raw_options, since shlex.split() would otherwise consume the
+        # surrounding whitespace before this code ever sees it.
+        assert GenericIntegration._resolve_commands_dir(
+            {}, {"raw_options": f"--commands-dir='{padded}'"}
+        ) == padded
 
     @pytest.mark.parametrize("raw", ["--commands-dir=", "--commands-dir ''", '--commands-dir ""'])
     def test_resolve_commands_dir_rejects_empty_raw_value(self, raw):