Restore source-agnostic artifact provenance

Assisted-by: GitHub Copilot (model: GPT-5.4, autonomous)

Co-authored-by: nicolehaugen <10600161+nicolehaugen@users.noreply.github.com>

Author: Copilot

src/specify_cli/_identifier.py

@@ -1,9 +1,9 @@
 """Deterministic identifiers for Spec Kit contributions and resolved stack layers.
 
 Every command, template, script, and hook contribution surfaced by a preset or
-extension manifest carries a computed opaque ``id`` string, and every layer of a
-resolved artifact stack carries a matching ``lookupId``. The identifier value is
-derived only from author-declared manifest data — it never depends on file
+extension manifest carries a computed opaque ``id`` string, and provenance-backed
+layers of a resolved artifact stack carry a matching ``lookupId``. The identifier
+value is derived only from author-declared manifest data — it never depends on file
 contents, timestamps, archive hashes, installation directory paths, install-time
 random values, or list positions. That is what makes identifiers portable
 across machines, project locations, and reinstalls, and what lets consumers use
@@ -23,9 +23,7 @@
     id = "{layer}:{sourceId}:hook:{eventName}:{command}"
 
 Built-in artifacts have no public layer or lookup identifier. Their public
-identifier is source-agnostic: ``"{kind}:{name}"``. The pre-existing resolver
-still uses ``core:_:...`` lookup IDs internally; consumers that expose public
-artifact data translate those IDs at their boundary.
+identifier is source-agnostic: ``"{kind}:{name}"``.
 
 The functions in this module are pure — inputs are strings or in-memory
 mappings parsed from a manifest, outputs are strings. None of them read from
@@ -51,7 +49,7 @@
 is the correct outcome for a layer with no originating manifest entry.
 """
 
-_LAYER_KINDS = frozenset({"core", PROJECT_OVERRIDE_LAYER, "preset", "extension"})
+_LAYER_KINDS = frozenset({PROJECT_OVERRIDE_LAYER, "preset", "extension"})
 _CONTRIBUTION_KINDS = frozenset({"command", "template", "script", "hook"})
 _NAMED_CONTRIBUTION_KINDS = _CONTRIBUTION_KINDS - {"hook"}
 
@@ -122,8 +120,8 @@ def layer_kind_from_lookup_id(lookup_id: str) -> str | None:
 
     ``lookupId`` values on resolved stack layers follow the same
     ``"{layer}:..."`` grammar as manifest-contribution ``id`` values (see
-    module docstring), including ``core`` for built-in layers and
-    :data:`PROJECT_OVERRIDE_LAYER` for project-local override layers.
+    module docstring), including :data:`PROJECT_OVERRIDE_LAYER` for project-local
+    override layers.
     This is the single place that knows the set of valid layer prefixes, so
     consumers can classify a lookupId without re-deriving the grammar via
     string-prefix checks of their own.

src/specify_cli/artifacts/__init__.py

@@ -236,18 +236,10 @@ def _public_layer_shape(
 ) -> tuple[LayerName | None, str | None, str | None]:
     """Translate resolver provenance into the public layer identity triple.
 
-    The resolver preserves its pre-existing built-in identity with
-    ``source == "core"`` and a ``core:_:`` lookup ID. Public artifact output
-    omits that tier's identity while retaining preset, extension, and project
-    override identities unchanged.
+    Layers without a lookup identifier have no public provenance. Preset,
+    extension, and project override identities are retained unchanged.
     """
     lookup_id = resolver_layer.get("lookupId")
-    if (
-        resolver_layer.get("source") == "core"
-        and isinstance(lookup_id, str)
-        and lookup_id.startswith("core:_:")
-    ):
-        return None, None, None
     if lookup_id is None:
         return None, None, None
     if not isinstance(lookup_id, str):

src/specify_cli/presets/__init__.py

@@ -5784,9 +5784,6 @@ def _find_in_subdirs(base_dir: Path) -> Optional[Path]:
                 "path": core,
                 "source": "core",
                 "strategy": "replace",
-                "lookupId": derive_named_id(
-                    "core", "_", template_type, template_name
-                ),
             })
         else:
             # Priority 5: Bundled core_pack (wheel install) or repo-root
@@ -5797,9 +5794,6 @@ def _find_in_subdirs(base_dir: Path) -> Optional[Path]:
                     "path": bundled,
                     "source": "core",
                     "strategy": "replace",
-                    "lookupId": derive_named_id(
-                        "core", "_", template_type, template_name
-                    ),
                 })
 
         return layers

tests/test_artifact_command.py

@@ -474,7 +474,7 @@ def test_builtin_row_shape(self, spec_kit_project: Path):
             "speckit.constitution", "command"
         )[-1]
         assert resolver_layer["source"] == "core"
-        assert resolver_layer["lookupId"] == "core:_:command:speckit.constitution"
+        assert "lookupId" not in resolver_layer
 
         info = ArtifactCatalog(spec_kit_project).get_artifact_info("speckit.constitution")
         assert info["id"] == "command:speckit.constitution"

tests/test_contribution_ids.py

@@ -122,7 +122,6 @@ class TestIdentifierDerivation:
             ("project", "_", "command", "speckit.constitution", "project:_:command:speckit.constitution"),
             ("project", "_", "template", "spec-template", "project:_:template:spec-template"),
             ("project", "_", "script", "setup-plan", "project:_:script:setup-plan"),
-            ("core", "_", "command", "speckit.plan", "core:_:command:speckit.plan"),
             ("preset", "speckit-core", "command", "speckit.plan", "preset:speckit-core:command:speckit.plan"),
             ("preset", "speckit-core", "template", "spec-template", "preset:speckit-core:template:spec-template"),
             ("preset", "speckit-core", "script", "setup-plan", "preset:speckit-core:script:setup-plan"),
@@ -157,6 +156,7 @@ def test_public_id_is_source_agnostic(self):
         [
             ("preset", "speckit-core", "hook", "before_plan:speckit.plan"),
             ("unknown", "source", "command", "speckit.plan"),
+            ("core", "_", "command", "speckit.plan"),
         ],
     )
     def test_named_id_rejects_invalid_layer_or_kind(self, args):
@@ -179,7 +179,6 @@ class TestLayerKindFromLookupId:
     @pytest.mark.parametrize(
         "lookup_id, expected",
         [
-            ("core:_:command:speckit.plan", "core"),
             ("preset:speckit-core:template:spec-template", "preset"),
             ("extension:speckit-git:script:post-commit", "extension"),
             (f"{PROJECT_OVERRIDE_LAYER}:_:template:spec-template", PROJECT_OVERRIDE_LAYER),
@@ -197,6 +196,7 @@ def test_recognized_layer_prefixes(self, lookup_id, expected):
         [
             "",
             "bogus:_:command:speckit.plan",
+            "core:_:command:speckit.plan",
             "core",
             ":_:command:speckit.plan",
             "core:not-an-id",
@@ -385,7 +385,7 @@ def test_builtin_layer_preserves_resolver_provenance(self, tmp_path):
         resolver.templates_dir = project / "templates"
         layers = resolver.collect_all_layers("spec-template", "template")
         builtin_layer = next(layer for layer in layers if layer["source"] == "core")
-        assert builtin_layer["lookupId"] == "core:_:template:spec-template"
+        assert "lookupId" not in builtin_layer
 
     def test_preset_layer_lookup_id_matches_manifest_contribution_id(self, tmp_path):
         project = _make_project(tmp_path)

tests/test_presets.py

@@ -1707,7 +1707,7 @@ def test_collect_all_layers_finds_bundled_core_without_specify_commands(
         layers = resolver.collect_all_layers("speckit.implement", "command")
         assert layers, "expected a bundled core base layer to be found"
         assert layers[-1]["source"] == "core"
-        assert layers[-1]["lookupId"] == "core:_:command:speckit.implement"
+        assert "lookupId" not in layers[-1]
         assert layers[-1]["path"].parts[-2:] == ("commands", "implement.md")
 
     def test_resolve_command_falls_back_to_bundled_core(self, project_dir):
@@ -12883,7 +12883,7 @@ def test_single_core_layer(self, project_dir):
         layers = resolver.collect_all_layers("spec-template")
         assert len(layers) == 1
         assert layers[0]["source"] == "core"
-        assert layers[0]["lookupId"] == "core:_:template:spec-template"
+        assert "lookupId" not in layers[0]
         assert layers[0]["strategy"] == "replace"
 
     def test_layers_include_presets(self, project_dir, temp_dir, valid_pack_data):