Commit 36a4745
fix(github): repair the json_escape test harness and re-sync with core
Two CI failures, both mine.
The json_escape parity tests wrote their payload into a per-script
subdirectory of tmp_path that nothing created, so every parametrised
case died with FileNotFoundError before reaching an assertion. They had
never run: bare `bash` resolves to the WSL launcher on my machine, so
`requires_bash` skipped them locally and CI was their first execution.
The helper now creates the directory.
The command-parity test then caught a real drift, which is what it is
for. Upstream #4456 changed core's taskstoissues to report an unreadable
extensions.yml instead of skipping hooks silently, in both the before
and after hook blocks. The extension copy still carried the old wording,
so the diff against core grew from 10 lines to 14. Ported both lines
rather than relaxing the assertion; the diff is back to the three script
paths plus the two that read the new TASKS value.
Rebased onto main to pick up that change.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent eb9916f commit 36a4745
2 files changed
Lines changed: 5 additions & 2 deletions
File tree
- extensions/github/commands
- tests/extensions/github
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
602 | 602 | | |
603 | 603 | | |
604 | 604 | | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
605 | 608 | | |
606 | 609 | | |
607 | 610 | | |
| |||
0 commit comments