Revert "add support for fields in issue read"

This reverts commit 56f35f5.

Author: iulia-b

pkg/github/issues_test.go

@@ -275,91 +275,6 @@ func Test_GetIssue(t *testing.T) {
 	}
 }
 
-func Test_GetIssue_FieldValues(t *testing.T) {
-	// Verify that issue_field_values from the REST API are present in the returned object.
-	serverTool := IssueRead(translations.NullTranslationHelper)
-
-	mockIssueWithFields := &github.Issue{
-		Number:  github.Ptr(99),
-		Title:   github.Ptr("Issue with field values"),
-		Body:    github.Ptr("body"),
-		State:   github.Ptr("open"),
-		HTMLURL: github.Ptr("https://github.com/owner/repo/issues/99"),
-		User: &github.User{
-			Login: github.Ptr("testuser"),
-		},
-		IssueFieldValues: []*github.IssueFieldValue{
-			{
-				IssueFieldID: 1001,
-				NodeID:       "FV_node_1",
-				DataType:     "single_select",
-				Value:        "High",
-				SingleSelectOption: &github.IssueFieldValueSingleSelectOption{
-					ID:    42,
-					Name:  "High",
-					Color: "red",
-				},
-			},
-			{
-				IssueFieldID: 1002,
-				NodeID:       "FV_node_2",
-				DataType:     "text",
-				Value:        "some text value",
-			},
-		},
-	}
-
-	mockedClient := MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
-		GetReposIssuesByOwnerByRepoByIssueNumber: mockResponse(t, http.StatusOK, mockIssueWithFields),
-	})
-
-	client := github.NewClient(mockedClient)
-	cache := stubRepoAccessCache(nil, 15*time.Minute)
-	flags := stubFeatureFlags(map[string]bool{"lockdown-mode": false})
-	deps := BaseDeps{
-		Client:          client,
-		GQLClient:       defaultGQLClient,
-		RepoAccessCache: cache,
-		Flags:           flags,
-	}
-	handler := serverTool.Handler(deps)
-
-	request := createMCPRequest(map[string]any{
-		"method":       "get",
-		"owner":        "owner",
-		"repo":         "repo",
-		"issue_number": float64(99),
-	})
-	result, err := handler(ContextWithDeps(context.Background(), deps), &request)
-	require.NoError(t, err)
-	require.NotNil(t, result)
-
-	textContent := getTextResult(t, result)
-
-	var returnedIssue MinimalIssue
-	err = json.Unmarshal([]byte(textContent.Text), &returnedIssue)
-	require.NoError(t, err)
-
-	require.Len(t, returnedIssue.IssueFieldValues, 2, "expected two issue field values")
-
-	first := returnedIssue.IssueFieldValues[0]
-	assert.Equal(t, int64(1001), first.IssueFieldID)
-	assert.Equal(t, "FV_node_1", first.NodeID)
-	assert.Equal(t, "single_select", first.DataType)
-	assert.Equal(t, "High", first.Value)
-	require.NotNil(t, first.SingleSelectOption)
-	assert.Equal(t, int64(42), first.SingleSelectOption.ID)
-	assert.Equal(t, "High", first.SingleSelectOption.Name)
-	assert.Equal(t, "red", first.SingleSelectOption.Color)
-
-	second := returnedIssue.IssueFieldValues[1]
-	assert.Equal(t, int64(1002), second.IssueFieldID)
-	assert.Equal(t, "FV_node_2", second.NodeID)
-	assert.Equal(t, "text", second.DataType)
-	assert.Equal(t, "some text value", second.Value)
-	assert.Nil(t, second.SingleSelectOption)
-}
-
 func Test_AddIssueComment(t *testing.T) {
 	// Verify tool definition once
 	serverTool := AddIssueComment(translations.NullTranslationHelper)

pkg/github/minimal_types.go

@@ -169,45 +169,28 @@ type MinimalReactions struct {
 	Eyes       int `json:"eyes"`
 }
 
-// MinimalIssueFieldValueSingleSelectOption is the trimmed output type for a single-select option of an issue field value.
-type MinimalIssueFieldValueSingleSelectOption struct {
-	ID    int64  `json:"id"`
-	Name  string `json:"name"`
-	Color string `json:"color"`
-}
-
-// MinimalIssueFieldValue is the trimmed output type for a custom field value attached to an issue.
-type MinimalIssueFieldValue struct {
-	IssueFieldID       int64                                     `json:"issue_field_id"`
-	NodeID             string                                    `json:"node_id"`
-	DataType           string                                    `json:"data_type"`
-	Value              any                                       `json:"value"`
-	SingleSelectOption *MinimalIssueFieldValueSingleSelectOption `json:"single_select_option,omitempty"`
-}
-
 // MinimalIssue is the trimmed output type for issue objects to reduce verbosity.
 type MinimalIssue struct {
-	Number            int                      `json:"number"`
-	Title             string                   `json:"title"`
-	Body              string                   `json:"body,omitempty"`
-	State             string                   `json:"state"`
-	StateReason       string                   `json:"state_reason,omitempty"`
-	Draft             bool                     `json:"draft,omitempty"`
-	Locked            bool                     `json:"locked,omitempty"`
-	HTMLURL           string                   `json:"html_url,omitempty"`
-	User              *MinimalUser             `json:"user,omitempty"`
-	AuthorAssociation string                   `json:"author_association,omitempty"`
-	Labels            []string                 `json:"labels,omitempty"`
-	Assignees         []string                 `json:"assignees,omitempty"`
-	Milestone         string                   `json:"milestone,omitempty"`
-	Comments          int                      `json:"comments,omitempty"`
-	Reactions         *MinimalReactions        `json:"reactions,omitempty"`
-	CreatedAt         string                   `json:"created_at,omitempty"`
-	UpdatedAt         string                   `json:"updated_at,omitempty"`
-	ClosedAt          string                   `json:"closed_at,omitempty"`
-	ClosedBy          string                   `json:"closed_by,omitempty"`
-	IssueType         string                   `json:"issue_type,omitempty"`
-	IssueFieldValues  []MinimalIssueFieldValue `json:"issue_field_values,omitempty"`
+	Number            int               `json:"number"`
+	Title             string            `json:"title"`
+	Body              string            `json:"body,omitempty"`
+	State             string            `json:"state"`
+	StateReason       string            `json:"state_reason,omitempty"`
+	Draft             bool              `json:"draft,omitempty"`
+	Locked            bool              `json:"locked,omitempty"`
+	HTMLURL           string            `json:"html_url,omitempty"`
+	User              *MinimalUser      `json:"user,omitempty"`
+	AuthorAssociation string            `json:"author_association,omitempty"`
+	Labels            []string          `json:"labels,omitempty"`
+	Assignees         []string          `json:"assignees,omitempty"`
+	Milestone         string            `json:"milestone,omitempty"`
+	Comments          int               `json:"comments,omitempty"`
+	Reactions         *MinimalReactions `json:"reactions,omitempty"`
+	CreatedAt         string            `json:"created_at,omitempty"`
+	UpdatedAt         string            `json:"updated_at,omitempty"`
+	ClosedAt          string            `json:"closed_at,omitempty"`
+	ClosedBy          string            `json:"closed_by,omitempty"`
+	IssueType         string            `json:"issue_type,omitempty"`
 }
 
 // MinimalIssuesResponse is the trimmed output for a paginated list of issues.
@@ -385,26 +368,6 @@ func convertToMinimalIssue(issue *github.Issue) MinimalIssue {
 		m.IssueType = issueType.GetName()
 	}
 
-	for _, fv := range issue.IssueFieldValues {
-		if fv == nil {
-			continue
-		}
-		mfv := MinimalIssueFieldValue{
-			IssueFieldID: fv.IssueFieldID,
-			NodeID:       fv.NodeID,
-			DataType:     fv.DataType,
-			Value:        fv.Value,
-		}
-		if opt := fv.SingleSelectOption; opt != nil {
-			mfv.SingleSelectOption = &MinimalIssueFieldValueSingleSelectOption{
-				ID:    opt.ID,
-				Name:  opt.Name,
-				Color: opt.Color,
-			}
-		}
-		m.IssueFieldValues = append(m.IssueFieldValues, mfv)
-	}
-
 	if r := issue.Reactions; r != nil {
 		m.Reactions = &MinimalReactions{
 			TotalCount: r.GetTotalCount(),