Skip to content

Commit 77452cc

Browse files
Tom ThorogoodCopilot
andcommitted
Require explicit user request before any PR approval, merge, or close
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent fc9415a commit 77452cc

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

‎.github/skills/pr-triage/SKILL.md‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,19 @@ Produce a table of open pull requests with CI status and a merge recommendation,
3333

3434
## Workflow
3535

36-
Resolve PRs in this order before generating the final table, since earlier PRs can block or affect CI for the rest:
36+
**Never approve, merge, or close a PR automatically. Every approval, merge, and close is a separate action the user must explicitly request, one at a time, regardless of the recommendation in the table.** This skill only produces recommendations and takes the read-only/branch-update actions described below on its own.
3737

38-
1. **Autofix PRs** (e.g. the `github-actions[bot]` collections-renames PR). These often correct data that other PRs' CI depends on, so merge them first.
38+
For prioritizing which PRs matter most when the user does ask for merges, note that these often correct data that other PRs' CI depends on, so they're worth flagging as high priority in that order:
39+
40+
1. **Autofix PRs** (e.g. the `github-actions[bot]` collections-renames PR).
3941
2. **Dependabot PRs** (`app/dependabot`).
4042
3. **Other `github-*`-login-submitted PRs** (e.g. `github-security-bot`).
4143

42-
Merge each blocking PR once its own CI passes, following the merge recommendation rules above. Only proceed to the next step once all blocking PRs are merged.
44+
Steps to actually perform without being asked:
4345

44-
4. Once all blocking PRs are merged, update every remaining open PR from the base branch (see below) to trigger fresh CI runs that reflect the newly merged fixes.
45-
5. Only after that, list open PRs with `gh pr list` including CI status (`statusCheckRollup`), read each PR's body/checkboxes, diff, and any bot triage comments (e.g. the maintainer triage comment posted by `explore-triage-commenter`), apply the merge recommendation rules, and present the table.
46-
6. Do not take merge/close actions on non-blocking PRs unless explicitly asked.
46+
1. Update every open PR from the base branch (see below) to trigger fresh CI runs.
47+
2. List open PRs with `gh pr list` including CI status (`statusCheckRollup`), read each PR's body/checkboxes, diff, and any bot triage comments (e.g. the maintainer triage comment posted by `explore-triage-commenter`), apply the merge recommendation rules, and present the table.
48+
3. Do not approve, merge, or close any PR — including ones recommended ✔️ or ❌ — without the user explicitly asking for that specific PR.
4749

4850
## Updating PR branches
4951

@@ -57,7 +59,7 @@ Workflow runs that require manual approval (e.g. first-time contributors) can be
5759
gh api -X POST repos/github/explore/actions/runs/<run_id>/approve
5860
```
5961

60-
Only do this for runs actually in `action_required` or `waiting` status — a 🔴 CI status from a completed, non-blocked run is a real failure, not a pending approval.
62+
Only do this for runs actually in `action_required` or `waiting` status — a 🔴 CI status from a completed, non-blocked run is a real failure, not a pending approval. As with PR approvals and merges, only approve a workflow run to unblock CI when the user has explicitly asked for that PR to move forward.
6163

6264
## Diagnosing CI failures
6365

0 commit comments

Comments
 (0)