C++: Exclude compiler generated variables from a case in 'cpp/leap-year/unsafe-array-for-days-of-the-year'.

Author: MathiasVP

cpp/ql/src/Likely Bugs/Leap Year/UnsafeArrayForDaysOfYear.ql

@@ -26,6 +26,7 @@ where
   or
   exists(Variable var |
     var = element and
+    not var.isCompilerGenerated() and
     var.getType() instanceof LeapYearUnsafeDaysOfTheYearArrayType and
     allocType = "an array allocation"
   )

cpp/ql/test/query-tests/Likely Bugs/Leap Year/UnsafeArrayForDaysOfYear/UnsafeArrayForDaysOfYear.expected

@@ -1,4 +1,3 @@
 | test.cpp:17:6:17:10 | items | There is an array allocation with a hard-coded set of 365 elements, which may indicate the number of days in a year without considering leap year scenarios. |
 | test.cpp:25:15:25:26 | new[] | There is an array allocation with a hard-coded set of 365 elements, which may indicate the number of days in a year without considering leap year scenarios. |
 | test.cpp:52:20:52:23 | call to vector | There is a std::vector allocation with a hard-coded set of 365 elements, which may indicate the number of days in a year without considering leap year scenarios. |
-| test.cpp:78:11:78:29 | __PRETTY_FUNCTION__ | There is an array allocation with a hard-coded set of 365 elements, which may indicate the number of days in a year without considering leap year scenarios. |

cpp/ql/test/query-tests/Likely Bugs/Leap Year/UnsafeArrayForDaysOfYear/test.cpp

@@ -75,5 +75,5 @@ void f_______________________________________________________this_name_must_be_e
   // and `()`). in this case, this adds up to exactly 364 characters.
   // The initializer for `__PRETTY_FUNCTION__` thus initializes an array of
   // length 365 (because the null-terminator adds another character).
-  auto x = __PRETTY_FUNCTION__; // $ SPURIOUS: Alert
+  auto x = __PRETTY_FUNCTION__; // clean
 }