Rust: Rename isConstant -> hasConstant.

Author: geoffw0

rust/ql/lib/codeql/rust/security/HardcodedCryptographicValueExtensions.qll

@@ -62,19 +62,19 @@ module HardcodedCryptographicValue {
   abstract class Barrier extends DataFlow::Node { }
 
   /**
-   * Holds if `e` is a literal or a combination of literals that is constant.
+   * Holds if `e` is a literal or a combination of literals that may be a constant.
    */
-  private predicate isConstant(Expr e) {
+  private predicate hasConstant(Expr e) {
     e instanceof LiteralExpr // e.g. `0`
     or
-    forex(Expr elem | elem = e.(ArrayListExpr).getExpr(_) | isConstant(elem)) // e.g. `[0, 0, 0, 0]`
+    forex(Expr elem | elem = e.(ArrayListExpr).getExpr(_) | hasConstant(elem)) // e.g. `[0, 0, 0, 0]`
     or
-    isConstant(e.(ArrayRepeatExpr).getRepeatOperand()) // e.g. `[0; 10]`
+    hasConstant(e.(ArrayRepeatExpr).getRepeatOperand()) // e.g. `[0; 10]`
     or
     // a match expression with one or more constant arms; taint would reach here
     // anyway, but we make it a source to avoid reporting many similar results
     // on each match arm.
-    isConstant(e.(MatchExpr).getMatchArmList().getAnArm().getExpr())
+    hasConstant(e.(MatchExpr).getMatchArmList().getAnArm().getExpr())
     or
     // e.g. `const MY_CONST: u64 = ...`
     // the constant initializer / body is the preferred source location for flow paths, when available.
@@ -86,15 +86,15 @@ module HardcodedCryptographicValue {
     not exists(e.(ConstAccess).getConst().getBody())
     or
     // e.g. `1 << 4`
-    isConstant(e.(BinaryExpr).getLhs()) and
-    isConstant(e.(BinaryExpr).getRhs())
+    hasConstant(e.(BinaryExpr).getLhs()) and
+    hasConstant(e.(BinaryExpr).getRhs())
   }
 
   /**
    * A constant, considered as a flow source.
    */
   private class ConstantSource extends Source {
-    ConstantSource() { isConstant(this.asExpr()) }
+    ConstantSource() { hasConstant(this.asExpr()) }
   }
 
   /**