Merge pull request #22042 from github/jketema/go-1.27

Go: Update to 1.27

Author: jketema

MODULE.bazel

@@ -302,7 +302,7 @@ use_repo(
 )
 
 go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk")
-go_sdk.download(version = "1.26.6")
+go_sdk.download(version = "1.27.0")
 
 go_deps = use_extension("@gazelle//:extensions.bzl", "go_deps")
 go_deps.from_file(go_mod = "//go/extractor:go.mod")

docs/codeql/reusables/supported-versions-compilers.rst

@@ -17,7 +17,7 @@
 
    .NET 5, .NET 6, .NET 7, .NET 8, .NET 9, .NET 10","``.sln``, ``.slnx``, ``.csproj``, ``.cs``, ``.cshtml``, ``.xaml``"
    GitHub Actions,"Not applicable",Not applicable,"``.github/workflows/*.yml``, ``.github/workflows/*.yaml``, ``**/action.yml``, ``**/action.yaml``"
-   Go (aka Golang), "Go up to 1.26", "Go 1.11 or more recent", ``.go``
+   Go (aka Golang), "Go up to 1.27", "Go 1.11 or more recent", ``.go``
    Java,"Java 7 to 26 [5]_","javac (OpenJDK and Oracle JDK),
 
    Eclipse compiler for Java (ECJ) [6]_",``.java``

go/actions/test/action.yml

@@ -4,7 +4,7 @@ inputs:
   go-test-version:
     description: Which Go version to use for running the tests
     required: false
-    default: "~1.26.6"
+    default: "~1.27.0"
   run-code-checks:
     description: Whether to run qhelp generation checks
     required: false

go/extractor/autobuilder/build-environment.go

@@ -12,7 +12,7 @@ import (
 )
 
 var minGoVersion = util.NewSemVer("1.11")
-var maxGoVersion = util.NewSemVer("1.26")
+var maxGoVersion = util.NewSemVer("1.27")
 
 type versionInfo struct {
 	goModVersion util.SemVer // The version of Go found in the go directive in the `go.mod` file.

go/extractor/extractor.go

@@ -1657,8 +1657,30 @@ func extractType(tw *trap.Writer, tp types.Type) trap.Label {
 			// parent scope, so they are not dealt with by `extractScopes`
 			for i := 0; i < origintp.NumMethods(); i++ {
 				meth := origintp.Method(i).Origin()
-
 				extractMethod(tw, meth)
+
+				// Consider a generic struct and a generic method:
+				//
+				//   type S[P any] struct{}
+				//   func (*S[P]) m[Q any](x Q) {}
+				//
+				// If we have a variable 's' of type 'S[int]' and the expression
+				// 's.m[string]("")', then the type of the selector expression 's.m'
+				// is '	func(Q)'. The method 'm' here is an instantiation of the
+				// declaration, which has its own type with type parameter 'Q'.
+				// As we do not extract method instantiations, 'populateTypeParamParents'
+				// does not automatically get called for the type parameter 'Q'
+				// from the instantiation of 'm'. To compensate, we add the type
+				// parameters here.
+				//
+				// As a parent we use the origin method. This suffices, as the name
+				// and index of the type parameter in the instantiation will be
+				// identical to those of the uninstantiated method, and as only
+				// these two properties will be extracted for a type parameter.
+				if tp.Method(i) != meth {
+					signature := tp.Method(i).Type().(*types.Signature)
+					populateTypeParamParents(signature.TypeParams(), meth, false)
+				}
 			}
 
 			underlyingInterface, underlyingIsInterface := underlying.(*types.Interface)

go/extractor/go.mod

@@ -1,8 +1,8 @@
 module github.com/github/codeql-go/extractor
 
-go 1.26
+go 1.27
 
-toolchain go1.26.6
+toolchain go1.27.0
 
 // when updating this, run
 //    bazel run @rules_go//go -- mod tidy

go/extractor/toolchain/toolchain_test.go

@@ -8,9 +8,9 @@ import (
 
 func TestParseGoVersion(t *testing.T) {
 	tests := map[string]string{
-		"go version go1.18.9 linux/amd64":            "go1.18.9",
-		"go version go1.26.3-X:nodwarf5 linux/amd64": "go1.26.3",
-		"go version go1.26.3rc1 linux/amd64":         "go1.26.3rc1",
+		"go version go1.18.9 linux/amd64":                                                              "go1.18.9",
+		"go version go1.26.3-X:nodwarf5 linux/amd64":                                                   "go1.26.3",
+		"go version go1.26.3rc1 linux/amd64":                                                           "go1.26.3rc1",
 		"warning: GOPATH set to GOROOT (/usr/local/go) has no effect\ngo version go1.18.9 linux/amd64": "go1.18.9",
 	}
 	for input, expected := range tests {

go/extractor/trap/labels.go

@@ -187,7 +187,7 @@ func findMethodOnTypeWithGivenReceiver(tp types.Type, object types.Object) *type
 	if definedType, ok := tp.(*types.Named); ok {
 		for i := 0; i < definedType.NumMethods(); i++ {
 			meth := definedType.Method(i)
-			if object == meth.Type().(*types.Signature).Recv() {
+			if object == meth.Type().(*types.Signature).Recv().Origin() {
 				return meth
 			}
 		}

go/ql/lib/change-notes/2026-06-25-go-1.27.md

@@ -0,0 +1,4 @@
+---
+category: majorAnalysis
+---
+* Go 1.27 is now supported.

go/ql/test/library-tests/semmle/go/Function/GenericFunctionInstantiationExpr.expected

@@ -6,3 +6,5 @@
 | genericFunctions.go:45:6:45:50 | generic function instantiation expression | genericFunctions.go:45:6:45:33 | GenericFunctionTwoTypeParams | 1 | genericFunctions.go:45:43:45:49 | float64 |
 | genericFunctions.go:141:6:141:41 | generic function instantiation expression | genericFunctions.go:141:6:141:33 | GenericFunctionInAnotherFile | 0 | genericFunctions.go:141:35:141:40 | string |
 | genericFunctions.go:146:6:146:55 | generic function instantiation expression | genericFunctions.go:146:6:146:47 | selection of GenericFunctionInAnotherPackage | 0 | genericFunctions.go:146:49:146:54 | string |
+| genericMethods.go:13:2:13:23 | generic function instantiation expression | genericMethods.go:13:2:13:18 | selection of GenericMethod1 | 0 | genericMethods.go:13:20:13:22 | int |
+| genericMethods.go:14:2:14:26 | generic function instantiation expression | genericMethods.go:14:2:14:18 | selection of GenericMethod2 | 0 | genericMethods.go:14:20:14:25 | string |