Apply batched suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: asgerf

unified/ql/lib/codeql/unified/internal/AnalysisQuality.qll

@@ -7,8 +7,8 @@ private import codeql.unified.internal.NameBindingPlugin
 /** Stats about identifiers that static name binding could resolve. */
 module StaticNameResolutionStats implements EntityStatsSig {
   /**
-   * Holds if `name` has been positively identified as something that refer to a value, and static name binding
-   * is thus not expected to resolve its members.
+   * Holds if `name` has been positively identified as referring to a value, so static name binding
+   * is not expected to resolve its members.
    */
   private predicate resolvesToValue(Identifier name) {
     exists(AstNode decl |

unified/ql/lib/codeql/unified/internal/NameBindingPlugin.qll

@@ -29,8 +29,7 @@ class NameBindingPlugin extends Unit {
   /**
    * Holds if `member` can be inherited by subclasses of `cls`.
    *
-   * The caller has already restricted `member` to be a member of `cls`, and
-   * ensured that `member` is a `VariableDeclaration` or `FunctionDeclaration`.
+   * The caller has already restricted `member` to be a member of `cls`.
    */
   bindingset[cls, member]
   predicate isInheritableMember(ClassLikeDeclaration cls, Member member) { none() }

unified/ql/lib/codeql/unified/internal/StaticNameBinding.qll

@@ -64,6 +64,8 @@ class NameBindingNode extends TNameBindingNode {
     or
     this.isStaticMemberNamespace(result)
     or
+    this.isInstanceMemberNamespace(result)
+    or
     this.isLocalNamespace(result)
     or
     this.isModuleScopeNode(result)
@@ -314,7 +316,7 @@ private predicate derivedStoreReadStep(NameBindingNode node1, NameBindingNode no
   )
 }
 
-/** Holds if the member represented by `node` cannot be inherited. */
+/** Holds if the member represented by `node` can be inherited. */
 pragma[nomagic]
 private predicate isInheritableMemberNode(NameBindingNode node) {
   exists(NameDeclaration decl |
@@ -563,7 +565,7 @@ private module FolderHeuristic {
 /**
  * Holds if `access` may resolve to `target` through the enclosing `accessingClass`.
  *
- * `instanceAccess` indicates if this this member should be accessed as an instance of `accessingClass`
+ * `instanceAccess` indicates whether this member should be accessed as an instance of `accessingClass`
  * or as a static member.
  */
 private predicate unqualifiedMemberAccessCand(

unified/ql/test/library-tests/static-name-binding/unqualified-access.swift

@@ -10,7 +10,7 @@ class ASub : A { // $ access=A
 
     class BSub : B { // $ access=A.B
         let x3: B = nil; // $ access=A.B
-        let x4: C = nil; // $ access=A.B.C // spurious result from folder-based heuristic
+        let x4: C = nil; // $ access=A.B.C
     }
 
     class BSub2 : B { // $ access=A.B