Update go/ql/lib/semmle/go/frameworks/AwsLambda.qll

atorralba · smowton · atorralba · commit 8d6aa281b931 · 2024-01-19T10:48:34.000+01:00
Co-authored-by: Chris Smowton &lt;smowton@github.com&gt;
diff --git a/go/ql/lib/semmle/go/frameworks/AwsLambda.qll b/go/ql/lib/semmle/go/frameworks/AwsLambda.qll
@@ -27,9 +27,9 @@ private class HandlerFunction extends FuncDef {
     or
     this = any(Method m | m.implements(awsLambdaPkg(), "Handler", "Invoke")).getFuncDecl()
     or
-    exists(ConversionExpr ce |
-      ce.getTypeExpr().getType() instanceof HandlerImpl and
-      this = ce.getOperand().(FunctionName).getTarget().getFuncDecl()
+    exists(DataFlow::TypeCastNode typeCast |
+      typeCast.getResultType() instanceof HandlerImpl and
+      this.(FuncDecl).getFunction().getARead() = typeCast.getOperand()
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,9 @@ private class HandlerFunction extends FuncDef {`
`27`	`27`	`or`
`28`	`28`	`this = any(Method m \| m.implements(awsLambdaPkg(), "Handler", "Invoke")).getFuncDecl()`
`29`	`29`	`or`
`30`		`- exists(ConversionExpr ce \|`
`31`		`- ce.getTypeExpr().getType() instanceof HandlerImpl and`
`32`		`- this = ce.getOperand().(FunctionName).getTarget().getFuncDecl()`
	`30`	`+ exists(DataFlow::TypeCastNode typeCast \|`
	`31`	`+ typeCast.getResultType() instanceof HandlerImpl and`
	`32`	`+ this.(FuncDecl).getFunction().getARead() = typeCast.getOperand()`
`33`	`33`	`)`
`34`	`34`	`}`
`35`	`35`	`}`