Skip to content

Commit 80ff183

Browse files
committed
unified: Detect and fix an invalid access path
1 parent 17e0a9a commit 80ff183

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

‎unified/ql/lib/codeql/unified/internal/mad/LegacyMaD.qll‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,10 @@ private module Debug {
358358
normalizedSourceModel(selector, ap, _, _)
359359
or
360360
normalizedSinkModel(selector, ap, _, _)
361+
or
362+
normalizedSummaryModel(selector, ap, _, _, _)
363+
or
364+
normalizedSummaryModel(selector, _, ap, _, _)
361365
) and
362366
ap.getName() = ["Argument", "Parameter"] and
363367
(

‎unified/ql/lib/ext/legacy-swift.model.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1164,7 +1164,7 @@ extensions:
11641164
- ["", "FilePath", true, "init(platformString:)", "", "", "Argument[platformString:]", "ReturnValue", "taint", "manual"]
11651165
- ["", "FilePath", true, "withPlatformString(_:)", "", "", "Argument[self]", "Argument[0].Parameter[0].CollectionElement", "taint", "manual"]
11661166
- ["", "FilePath", true, "withPlatformString(_:)", "", "", "Argument[0].ReturnValue", "ReturnValue", "taint", "manual"]
1167-
- ["", "FilePath", true, "init(_:root:)", "", "", "Argument[root:,1]", "ReturnValue", "taint", "manual"]
1167+
- ["", "FilePath", true, "init(_:root:)", "", "", "Argument[root:,0]", "ReturnValue", "taint", "manual"]
11681168
- ["", "FilePath", true, "init(components:root:)", "", "", "Argument[root:,components:]", "ReturnValue", "taint", "manual"]
11691169
- ["", "FilePath", true, "lexicallyNormalized()", "", "", "Argument[self]", "ReturnValue", "taint", "manual"]
11701170
- ["", "FilePath", true, "lexicallyResolving(_:)", "", "", "Argument[self,0]", "ReturnValue", "taint", "manual"]

0 commit comments

Comments
 (0)