Improve inaccurate deprecation comments

owen-mc · owen-mc · commit 08e1e8a1201f · 2023-08-10T15:50:08.000+01:00
diff --git a/go/ql/lib/semmle/go/security/AllocationSizeOverflow.qll b/go/ql/lib/semmle/go/security/AllocationSizeOverflow.qll
@@ -14,7 +14,7 @@ module AllocationSizeOverflow {
   import AllocationSizeOverflowCustomizations::AllocationSizeOverflow
 
   /**
-   * DEPRECATED: Use `FindLargeLensFlow` instead.
+   * DEPRECATED: Use a copy of `FindLargeLensConfig` and `FindLargeLensFlow` instead.
    *
    * A taint-tracking configuration for identifying `len(...)` calls whose argument may be large.
    */
diff --git a/go/ql/lib/semmle/go/security/UnsafeUnzipSymlink.qll b/go/ql/lib/semmle/go/security/UnsafeUnzipSymlink.qll
@@ -14,7 +14,7 @@ module UnsafeUnzipSymlink {
   import UnsafeUnzipSymlinkCustomizations::UnsafeUnzipSymlink
 
   /**
-   * DEPRECATED: Use `EvalSymlinksFlow` instead.
+   * DEPRECATED: Use a copy of `EvalSymlinksConfig` and `EvalSymlinksFlow` instead.
    *
    * A taint-flow configuration tracking archive header fields flowing to a `path/filepath.EvalSymlinks` call.
    */
diff --git a/go/ql/src/experimental/CWE-1004/AuthCookie.qll b/go/ql/src/experimental/CWE-1004/AuthCookie.qll
@@ -185,7 +185,7 @@ private module BoolToGinSetCookieTrackingConfig implements DataFlow::ConfigSig {
 module BoolToGinSetCookieTrackingFlow = DataFlow::Global<BoolToGinSetCookieTrackingConfig>;
 
 /**
- * DEPRECATED: Use `NameToGinSetCookieTrackingConfig` instead.
+ * DEPRECATED: Use `NameToGinSetCookieTrackingFlow` instead.
  *
  * A taint-tracking configuration for tracking flow from sensitive names to
  * `gin-gonic/gin.Context.SetCookie`.

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ module AllocationSizeOverflow {`
`14`	`14`	`import AllocationSizeOverflowCustomizations::AllocationSizeOverflow`
`15`	`15`
`16`	`16`	`/**`
`17`		- * DEPRECATED: Use `FindLargeLensFlow` instead.
	`17`	+ * DEPRECATED: Use a copy of `FindLargeLensConfig` and `FindLargeLensFlow` instead.
`18`	`18`	`*`
`19`	`19`	* A taint-tracking configuration for identifying `len(...)` calls whose argument may be large.
`20`	`20`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ module UnsafeUnzipSymlink {`
`14`	`14`	`import UnsafeUnzipSymlinkCustomizations::UnsafeUnzipSymlink`
`15`	`15`
`16`	`16`	`/**`
`17`		- * DEPRECATED: Use `EvalSymlinksFlow` instead.
	`17`	+ * DEPRECATED: Use a copy of `EvalSymlinksConfig` and `EvalSymlinksFlow` instead.
`18`	`18`	`*`
`19`	`19`	* A taint-flow configuration tracking archive header fields flowing to a `path/filepath.EvalSymlinks` call.
`20`	`20`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ private module BoolToGinSetCookieTrackingConfig implements DataFlow::ConfigSig {`
`185`	`185`	`module BoolToGinSetCookieTrackingFlow = DataFlow::Global<BoolToGinSetCookieTrackingConfig>;`
`186`	`186`
`187`	`187`	`/**`
`188`		- * DEPRECATED: Use `NameToGinSetCookieTrackingConfig` instead.
	`188`	+ * DEPRECATED: Use `NameToGinSetCookieTrackingFlow` instead.
`189`	`189`	`*`
`190`	`190`	`* A taint-tracking configuration for tracking flow from sensitive names to`
`191`	`191`	* `gin-gonic/gin.Context.SetCookie`.