Improve performance

Author: JarLob

csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/AspNetCore.qll

@@ -388,6 +388,21 @@ private predicate isDefaultMicrosoftAspNetCoreMvcController(Class controller) {
     MicrosoftAspNetCoreMvcNonControllerAttribute
 }
 
+private predicate isMicrosoftAspNetCoreMvcIDisposableMethod(Method method) {
+  exists(Method baseMethod |
+    baseMethod = method.getOverridee*() and
+    not exists(baseMethod.getOverridee()) and
+    (
+      baseMethod.getExplicitlyImplementedInterface() instanceof SystemIDisposableInterface
+      or
+      baseMethod.getUndecoratedName() = "Dispose" and
+      baseMethod.getNumberOfParameters() = 0 and
+      baseMethod.getReturnType() instanceof VoidType and
+      baseMethod.getDeclaringType().getABaseInterface*() instanceof SystemIDisposableInterface
+    )
+  )
+}
+
 /** A class treated as an owner of ASP.NET Core MVC controller helper methods. */
 class MicrosoftAspNetCoreMvcControllerHelperClass extends Class {
   MicrosoftAspNetCoreMvcControllerHelperClass() {
@@ -424,10 +439,10 @@ class MicrosoftAspNetCoreMvcController extends Class {
     result.isPublic() and
     not result.isStatic() and
     not result.isAbstract() and
-    not result.getUnboundDeclaration() instanceof UnboundGenericMethod and
+    not result instanceof Generic and
     not result.getOverridee*().getAnAttribute() instanceof MicrosoftAspNetCoreMvcNonActionAttribute and
     not result.getOverridee*().getDeclaringType() instanceof ObjectType and
-    not result instanceof DisposeMethod
+    not isMicrosoftAspNetCoreMvcIDisposableMethod(result)
   }
 
   /** Gets a `Redirect*`, `Accepted*`, or `Created*` method. */

csharp/ql/test/library-tests/frameworks/microsoft/AspNetCore.cs

@@ -196,3 +196,8 @@ internal void InternalAction(string input) { }
 
     private void PrivateAction(string input) { }
 }
+
+public class NewDisposeController : Controller
+{
+    public new void Dispose() { }
+}

csharp/ql/test/library-tests/frameworks/microsoft/AspNetCore.expected

@@ -10,3 +10,4 @@
 | AspNetCore.cs:155:14:155:36 | ClosedGenericController |
 | AspNetCore.cs:171:14:171:35 | ConcreteActionEndpoint |
 | AspNetCore.cs:178:14:178:34 | ActionCasesController |
+| AspNetCore.cs:200:14:200:33 | NewDisposeController |

csharp/ql/test/library-tests/frameworks/microsoft/AspNetCoreActions.expected

@@ -13,3 +13,4 @@
 | AspNetCore.cs:171:14:171:35 | ConcreteActionEndpoint | AspNetCore.cs:165:17:165:31 | InheritedAction |
 | AspNetCore.cs:171:14:171:35 | ConcreteActionEndpoint | AspNetCore.cs:173:26:173:39 | AbstractAction |
 | AspNetCore.cs:178:14:178:34 | ActionCasesController | AspNetCore.cs:180:17:180:28 | PublicAction |
+| AspNetCore.cs:200:14:200:33 | NewDisposeController | AspNetCore.cs:202:21:202:27 | Dispose |