Skip to content

Commit eeb8782

Browse files
refactor: enforce minimum one-second duration for registry TTL and MCP health intervals
Signed-off-by: Ankit Kr. Chowdhury <rakesh856100@gmail.com>
1 parent 72f558f commit eeb8782

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

cmd/main.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -219,29 +219,26 @@ func main() {
219219

220220
registryTTL := registry.DefaultTTL
221221
if v := os.Getenv("AGENTRAX_REGISTRY_TTL"); v != "" {
222-
if parsed, err := time.ParseDuration(v); err == nil && parsed > 0 {
222+
if parsed, err := time.ParseDuration(v); err == nil && parsed >= time.Second {
223223
registryTTL = parsed
224224
} else {
225-
setupLog.Error(err, "invalid or non-positive AGENTRAX_REGISTRY_TTL, using default",
225+
setupLog.Error(err, "invalid or sub-second AGENTRAX_REGISTRY_TTL (< 1s), using default",
226226
"default", registry.DefaultTTL)
227227
}
228228
}
229229

230230
mcpHealthInterval := 60 * time.Second
231231
if v := os.Getenv("AGENTRAX_MCP_HEALTH_INTERVAL"); v != "" {
232-
if parsed, err := time.ParseDuration(v); err == nil && parsed > 0 {
232+
if parsed, err := time.ParseDuration(v); err == nil && parsed >= time.Second {
233233
mcpHealthInterval = parsed
234234
} else {
235-
setupLog.Error(err, "invalid or non-positive AGENTRAX_MCP_HEALTH_INTERVAL, using default",
235+
setupLog.Error(err, "invalid or sub-second AGENTRAX_MCP_HEALTH_INTERVAL (< 1s), using default",
236236
"default", mcpHealthInterval)
237237
}
238238
}
239239

240240
if mcpHealthInterval >= registryTTL {
241241
adjusted := registryTTL / 2
242-
if adjusted <= 0 {
243-
adjusted = time.Second
244-
}
245242
setupLog.Info("AGENTRAX_MCP_HEALTH_INTERVAL must be strictly less than AGENTRAX_REGISTRY_TTL",
246243
"configuredInterval", mcpHealthInterval,
247244
"registryTTL", registryTTL,

0 commit comments

Comments
 (0)