From 02b5df274a2d613feeeaa1e808e60743c505f6a1 Mon Sep 17 00:00:00 2001 From: Toni Bergholm Date: Sat, 18 Jul 2026 13:26:27 +0300 Subject: [PATCH] =?UTF-8?q?ci:=20add=20CODEOWNERS=20+=20require=20code-own?= =?UTF-8?q?er=20review=20=E2=80=94=20closes=20last=20branch-protection=20r?= =?UTF-8?q?esidual?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit .github/CODEOWNERS names both admin accounts as owners of everything, with explicit callouts for crypto/tlsio, .github, and the security docs. The main ruleset's require_code_owner_review is now true (set live). This closes the one residual Scorecard BranchProtection sub-item ('codeowners review is not required'); the only remaining open code-scanning finding is the optional OpenSSF badge. Stacked on #89 (required-review docs). Updates ACCESS.md, opsec-baseline.md, and the fifth-round evidence delta. --- .github/CODEOWNERS | 17 +++++++++++++++++ docs/agents/ACCESS.md | 2 +- docs/audit/gap-analysis-source.md | 14 +++++++++++--- docs/security/opsec-baseline.md | 9 +++++---- 4 files changed, 34 insertions(+), 8 deletions(-) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 00000000..0fed6f95 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,17 @@ +# Code owners for src-control (OSTIF audit follow-up; completes the +# branch-protection control — the `main` ruleset requires code-owner review). +# Order matters: the LAST matching pattern for a path wins. Every listed owner +# must have write access, or the entry is silently ignored by GitHub. + +# Default: both maintainers own everything. +* @tonibergholm @tonibergholm-codento + +# Security-critical surfaces called out for documentation value (the owners are +# the same, but this records that these paths carry extra review weight — +# changes here also hit the CONTRIBUTING.md "Security-review triggers" list). +/crates/crypto/ @tonibergholm @tonibergholm-codento +/crates/tlsio/ @tonibergholm @tonibergholm-codento +/.github/ @tonibergholm @tonibergholm-codento +/docs/security/ @tonibergholm @tonibergholm-codento +/docs/THREAT-MODEL.md @tonibergholm @tonibergholm-codento +/SECURITY.md @tonibergholm @tonibergholm-codento diff --git a/docs/agents/ACCESS.md b/docs/agents/ACCESS.md index b92ae734..d9d3bf26 100644 --- a/docs/agents/ACCESS.md +++ b/docs/agents/ACCESS.md @@ -17,7 +17,7 @@ it as the revocation checklist. Written as OSTIF-audit follow-up T-14 (G-012). |---|---|---| | GitHub org owner (`git-agentic`) | Toni Bergholm (`tonibergholm`) | Org 2FA requirement **enforced** since 2026-07-18 (see [`opsec-baseline.md`](../security/opsec-baseline.md)). | | Repo admin (`git-agentic/src-control`) | `tonibergholm`, `tonibergholm-codento` | Both admin. Control rulesets, security toggles, secrets. | -| Reviewer (required PR approver) | `tonibergholm`, `tonibergholm-codento` | Since 2026-07-18 the `main` ruleset requires **1 approval** from a principal other than the last pusher, so the two accounts review each other's PRs (closes audit G-032). | +| Reviewer (required PR approver) | `tonibergholm`, `tonibergholm-codento` | Since 2026-07-18 the `main` ruleset requires **1 approval** from a principal other than the last pusher, plus **code-owner review** (`.github/CODEOWNERS` names both accounts), so the two accounts review each other's PRs (closes audit G-032). | | `git-agentic.com` DNS/registrar | Toni Bergholm | Out-of-repo credential. | | crates.io publish rights | — (N/A) | Workspace is `publish = false`; no crates.io tokens exist. Revisit at first release (audit T-24 trigger). | | Security-report handler | Toni Bergholm | Per [`vulnerability-response.md`](../security/vulnerability-response.md). | diff --git a/docs/audit/gap-analysis-source.md b/docs/audit/gap-analysis-source.md index 13a4d8b3..4fc945da 100644 --- a/docs/audit/gap-analysis-source.md +++ b/docs/audit/gap-analysis-source.md @@ -683,12 +683,20 @@ rule now has `required_approving_review_count: 1`, - **Scorecard consequence:** `CodeReviewID` (#14) and `BranchProtectionID` (#4) will improve/close on the next weekly scan (approvals now recorded; the branch-protection warnings for require-approvers, stale-dismissal, and - last-push-approval are all now satisfied — `require_code_owner_review` - stays false, a minor residual). The only remaining open code-scanning - finding is the optional `CIIBestPracticesID` badge (#16). + last-push-approval are all now satisfied). The only remaining open + code-scanning finding is the optional `CIIBestPracticesID` badge (#16). - **Operational note:** no principal — human, automation, or agent — can self-merge anymore; the two admin accounts review each other's PRs. +**Follow-up (same day): `.github/CODEOWNERS` added and code-owner review +required.** The one residual branch-protection sub-item — `codeowners review +is not required` — is now closed: `.github/CODEOWNERS` names both admin +accounts as owners of everything (with explicit callouts for +`crates/crypto`, `crates/tlsio`, `.github`, and the security docs), and the +ruleset's `require_code_owner_review` was set to `true` (verified live). The +`BranchProtectionID` check now has no residual warnings to raise. Only the +optional OpenSSF badge remains. + Every non-deferred gap in the 35-gap set is now resolved. Remaining: the Deferred tier T-22…T-25 (gated on a first distribution channel) and the two human/out-of-repo tails (`security.txt` deploy, subscription confirmation). diff --git a/docs/security/opsec-baseline.md b/docs/security/opsec-baseline.md index cf49f053..df9155a7 100644 --- a/docs/security/opsec-baseline.md +++ b/docs/security/opsec-baseline.md @@ -18,10 +18,11 @@ T-20 (G-025). - **Third-party actions are SHA-pinned** with a version comment; Dependabot maintains the pins (audit T-2). New actions enter SHA-pinned or not at all. - **Merges to `main` are ruleset-gated**: PR required, **1 required approval** - from a principal other than the last pusher (since 2026-07-18), stale - approvals dismissed on push, last-push approval required, four required - status checks, up-to-date branch, no force-push/deletion, no bypass actors. - Nobody self-merges — the two admin accounts review each other's PRs. + from a principal other than the last pusher (since 2026-07-18), **code-owner + review required** (`.github/CODEOWNERS`), stale approvals dismissed on push, + last-push approval required, four required status checks, up-to-date branch, + no force-push/deletion, no bypass actors. Nobody self-merges — the two admin + accounts review each other's PRs. ## Accounts and devices