From ea8a6cfa48d866b0ebd6ae82fa21e0c2fe1db23b Mon Sep 17 00:00:00 2001 From: Toni Bergholm Date: Tue, 20 Oct 2026 07:46:02 +0300 Subject: [PATCH 1/5] feat(repo,cli): serve token expiry and rotate (#209) Add optional expires_at to serve tokens (sc serve token add --expires), reject expired tokens in verify with the same 401 as unknown ones, flag them in list, and add sc serve token rotate. Expired entries stay in the file (ADR-0040 addendum). --- ROADMAP.md | 8 +- crates/cli/src/main.rs | 47 ++++- crates/cli/tests/http_remote.rs | 55 ++++++ crates/repo/src/http_transport.rs | 2 +- crates/repo/src/serve_tokens.rs | 252 ++++++++++++++++++++++-- docs/adr/0040-sc-http-access-control.md | 21 +- 6 files changed, 364 insertions(+), 21 deletions(-) diff --git a/ROADMAP.md b/ROADMAP.md index 8ee5352b..932e1769 100644 --- a/ROADMAP.md +++ b/ROADMAP.md @@ -816,9 +816,13 @@ scale-&-reach horizon): - **Per-path/per-ref ACLs (P29).** `sc serve --http` access control is all-or-nothing per connection (`ro`/`rw`); scoping a token to specific path prefixes or refs is beyond the MVP. Deferred. -- **Token expiry/rotation metadata (P29).** `sct-` tokens have no expiry +- ~~**Token expiry/rotation metadata (P29).** `sct-` tokens have no expiry field; rotation today is add-new + remove-old with no automation or - reminder. Deferred. + reminder.~~ **Done.** (#209) `sc serve token add --expires <30d|2030-01-31>` + stores an optional `expires_at` (Unix seconds); `verify` treats an expired + token like an unknown one (`401`); `list` shows and flags expiry; `sc serve + token rotate