Repository navigation
Commit e540bd6
test: Fix tests that could not fail (#8288)
Fixes tests that [falsegreen](https://github.com/vinicq/falsegreen)
flagged and that would keep passing even if the behavior they check
broke. Test-only change.
- `beam/test_beam.py::test_monkey_patch_signature`: the signature assert
sat in `try/except Exception: pass` (a py2.7 leftover), so the
`AssertionError` was swallowed. Removed the try.
-
`pydantic_ai/test_pydantic_ai.py::test_tool_execution_without_span_context`:
`agent.run` was wrapped in `except Exception: pass` and followed by
`assert True`. The run succeeds with the `test` model, so it now asserts
on the result.
- `test_envelope.py::test_add_and_get_session`: the assert sat inside
`for`/`if`, so a missing session item passed. It now unpacks exactly one
session item.
- `grpc/test_grpc.py` and `grpc/test_grpc_aio.py::test_stream_stream`:
an empty response stream passed. They now compare the collected
responses.
- `mcp/test_mcp.py::test_integration_patches_server`: on MCP v2 the
whole body was skipped behind `if not IS_MCP_V2`, so it passed without
running. It's now `skipif`.
- Dropped duplicate parametrize cases in
`test_utils.py::test_check_minimum_version` and
`test_client.py::test_init_string_types`.
<!-- junior-request-attribution:start -->
via @sentrivana.
<!-- junior-request-attribution:end -->
<!-- junior-session-footer:start -->
<!-- junior-conversation-id:slack%3AC0CAA8NNBE3%3A1794392136.309249 -->
--
[View
Session](https://junior-prod.sentry.dev/conversations/slack%3AC0CAA8NNBE3%3A1794392136.309249)
[[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0CAA8NNBE3%3A1794392136.309249/?project=4510944073809921)
<!-- junior-session-footer:end -->
---------
Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Co-authored-by: Ivana Kellyer <131587164+sentrivana@users.noreply.github.com>1 parent 4c1a136 commit e540bd6
8 files changed
Lines changed: 25 additions & 52 deletions
File tree
- tests
- integrations
- beam
- grpc
- mcp
- pydantic_ai
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
150 | 148 | | |
151 | | - | |
152 | | - | |
153 | | - | |
| 149 | + | |
154 | 150 | | |
155 | 151 | | |
156 | 152 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
666 | 666 | | |
667 | 667 | | |
668 | 668 | | |
669 | | - | |
670 | | - | |
| 669 | + | |
671 | 670 | | |
672 | 671 | | |
673 | 672 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
453 | 453 | | |
454 | 454 | | |
455 | 455 | | |
456 | | - | |
457 | | - | |
| 456 | + | |
458 | 457 | | |
459 | 458 | | |
460 | 459 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| 145 | + | |
145 | 146 | | |
146 | 147 | | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
151 | 151 | | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
156 | 156 | | |
157 | | - | |
158 | | - | |
159 | | - | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3591 | 3591 | | |
3592 | 3592 | | |
3593 | 3593 | | |
3594 | | - | |
3595 | | - | |
3596 | | - | |
3597 | | - | |
3598 | | - | |
3599 | | - | |
3600 | | - | |
3601 | | - | |
3602 | | - | |
| 3594 | + | |
| 3595 | + | |
3603 | 3596 | | |
3604 | 3597 | | |
3605 | 3598 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1038 | 1038 | | |
1039 | 1039 | | |
1040 | 1040 | | |
1041 | | - | |
1042 | | - | |
1043 | | - | |
1044 | | - | |
1045 | | - | |
1046 | | - | |
1047 | | - | |
1048 | | - | |
1049 | | - | |
1050 | | - | |
1051 | | - | |
1052 | | - | |
1053 | | - | |
1054 | | - | |
| 1041 | + | |
| 1042 | + | |
1055 | 1043 | | |
1056 | 1044 | | |
1057 | 1045 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
77 | | - | |
78 | | - | |
| 76 | + | |
| 77 | + | |
79 | 78 | | |
80 | 79 | | |
81 | 80 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
835 | 835 | | |
836 | 836 | | |
837 | 837 | | |
838 | | - | |
839 | 838 | | |
840 | 839 | | |
841 | 840 | | |
| |||
0 commit comments