Skip to content

Commit 3b49faf

Browse files
ref(profiling): Remove unused ContinuousScheduler.pause stub (#8224)
### Description Removes `ContinuousScheduler.pause()` from `sentry_sdk/profiler/continuous_profiler.py` (3 lines). It's a stub that only raises `NotImplementedError`, and nothing implements it or calls it. #2830 (Jun 2024, "Introduce continuous profiling mode") added it next to `ensure_running()` and `teardown()`. Unlike those two, no subclass ever overrode it, and the SDK never called it. The stub makes it look like the continuous profiler can be paused, but it can't. **Evidence** - `git grep -nw pause` on `master` finds only the definition. Nothing in `sentry_sdk/`, `tests/`, `scripts/` or `docs/` refers to it. - `ThreadContinuousScheduler` and `GeventContinuousScheduler`, the only subclasses, override `ensure_running()` and `teardown()` but not `pause()`. - `git log -S "def pause"` finds only #2830. `git log -S ".pause("` across `sentry_sdk` and `tests` finds no commits, so it has never had a caller. - `ContinuousScheduler` isn't exported from `sentry_sdk.profiler` (`__all__` lists only the transaction-profiler schedulers) and isn't documented. - No open PR or issue mentions it. #7275 also touches `continuous_profiler.py`, but in different hunks (`ThreadContinuousScheduler.__init__`). **Why it's safe** - `ContinuousScheduler` is an internal class. The method is unreachable, so behavior doesn't change, and no public API or documented behavior is affected. **Checks** - `uv run ruff check` / `ruff format --check` on `sentry_sdk/profiler`: clean - `uv run --group typing mypy sentry_sdk`: no issues - `TESTPATH=tests/profiler uv run tox -e py3.14-common`: 106 passed, 69 skipped. The skipped tests are the gevent cases, which need gevent installed. #### Issues None. Found by the weekly sentry-python removal scout. <!-- junior-request-attribution:start --> via [automation `sched_65eed06cc199036c2b13411096f412d4`](https://junior-prod.sentry.dev/automations/sched_65eed06cc199036c2b13411096f412d4) · Run ID `sched_65eed06cc199036c2b13411096f412d4:1794211200000`. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:agent-dispatch%3Adispatch_0096be51ec4ca0f294d1b5786520632b --> -- [View Session](https://junior-prod.sentry.dev/conversations/agent-dispatch%3Adispatch_0096be51ec4ca0f294d1b5786520632b) [[Sentry]](https://sentry.sentry.io/explore/conversations/agent-dispatch%3Adispatch_0096be51ec4ca0f294d1b5786520632b/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
1 parent d565fed commit 3b49faf

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

‎sentry_sdk/profiler/continuous_profiler.py‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -291,9 +291,6 @@ def ensure_running(self) -> None:
291291
def teardown(self) -> None:
292292
raise NotImplementedError
293293

294-
def pause(self) -> None:
295-
raise NotImplementedError
296-
297294
def reset_buffer(self) -> None:
298295
self.buffer = ProfileBuffer(
299296
self.options, self.sdk_info, PROFILE_BUFFER_SECONDS, self.capture_func

0 commit comments

Comments
 (0)