Skip to content

Commit 0edf177

Browse files
feat(bedrock): Record gen_ai.response.finish_reasons for non-streaming responses
1 parent fc6b034 commit 0edf177

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

‎sentry_sdk/integrations/boto3/_services/bedrock.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,10 @@ def on_success_response(
512512

513513
set_on_span(SPANDATA.GEN_AI_USAGE_INPUT_TOKENS, input_tokens)
514514

515+
set_on_span(
516+
SPANDATA.GEN_AI_RESPONSE_FINISH_REASONS, [response["stopReason"]]
517+
)
518+
515519
client = sentry_sdk.get_client()
516520
if "message" in response["output"] and (
517521
(

‎tests/integrations/boto3/test_bedrock.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -476,6 +476,9 @@ def test_converse(
476476
assert span["attributes"][SPANDATA.GEN_AI_REQUEST_MAX_TOKENS] == 1024
477477
assert span["attributes"][SPANDATA.GEN_AI_REQUEST_TEMPERATURE] == 0.7
478478
assert span["attributes"][SPANDATA.GEN_AI_REQUEST_TOP_P] == 0.9
479+
assert span["attributes"][SPANDATA.GEN_AI_RESPONSE_FINISH_REASONS] == [
480+
"end_turn"
481+
]
479482

480483
assert span["attributes"][SPANDATA.GEN_AI_USAGE_OUTPUT_TOKENS] == 20
481484
assert span["attributes"][SPANDATA.GEN_AI_USAGE_TOTAL_TOKENS] == 30
@@ -513,6 +516,7 @@ def test_converse(
513516
assert span["data"][SPANDATA.GEN_AI_REQUEST_MAX_TOKENS] == 1024
514517
assert span["data"][SPANDATA.GEN_AI_REQUEST_TEMPERATURE] == 0.7
515518
assert span["data"][SPANDATA.GEN_AI_REQUEST_TOP_P] == 0.9
519+
assert span["data"][SPANDATA.GEN_AI_RESPONSE_FINISH_REASONS] == ["end_turn"]
516520

517521
assert span["data"][SPANDATA.GEN_AI_USAGE_OUTPUT_TOKENS] == 20
518522
assert span["data"][SPANDATA.GEN_AI_USAGE_TOTAL_TOKENS] == 30

0 commit comments

Comments
 (0)