From 800fa9eb53f8ac30ea88d066ce2d2444766c87c1 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Thu, 9 Jul 2026 11:26:28 +0200 Subject: [PATCH] test: Remove fixed container_name from node integration test docker-compose files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A fixed `container_name` is a global name on the Docker daemon, not scoped to the Compose project. When a suite's teardown was skipped (process killed, crash, etc.), the orphaned container kept holding the name, and the next run's project-scoped `docker compose down` could not remove it — so `up` failed with "the container name ... is already in use". Nothing connects by container name (the app uses the published host port and healthchecks run inside the container), so dropping it lets Compose auto-name containers per project. Startup is then resilient to a leftover container without changing the existing teardown behaviour. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../suites/tracing/ioredis-dc/docker-compose.yml | 1 - .../suites/tracing/kafkajs/docker-compose.yml | 1 - .../suites/tracing/knex/mysql2/docker-compose.yml | 1 - .../suites/tracing/knex/pg/docker-compose.yml | 1 - .../suites/tracing/mysql2-tracing-channel/docker-compose.yml | 1 - .../suites/tracing/mysql2/docker-compose.yml | 1 - .../suites/tracing/postgres-streamed/docker-compose.yml | 1 - .../suites/tracing/postgres/docker-compose.yml | 1 - .../suites/tracing/postgresjs/docker-compose.yml | 1 - .../suites/tracing/prisma-orm-v5/docker-compose.yml | 1 - .../suites/tracing/prisma-orm-v6/docker-compose.yml | 1 - .../suites/tracing/prisma-orm-v7/docker-compose.yml | 1 - .../suites/tracing/redis-cache/docker-compose.yml | 1 - .../suites/tracing/redis-dc/docker-compose.yml | 1 - .../suites/tracing/redis/docker-compose.yml | 1 - .../suites/tracing/tedious/docker-compose.yml | 1 - 16 files changed, 16 deletions(-) diff --git a/dev-packages/node-integration-tests/suites/tracing/ioredis-dc/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/ioredis-dc/docker-compose.yml index 81814ee17518..ab3eed6265b6 100644 --- a/dev-packages/node-integration-tests/suites/tracing/ioredis-dc/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/ioredis-dc/docker-compose.yml @@ -4,7 +4,6 @@ services: db: image: redis:latest restart: always - container_name: integration-tests-ioredis-dc ports: - '6382:6379' healthcheck: diff --git a/dev-packages/node-integration-tests/suites/tracing/kafkajs/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/kafkajs/docker-compose.yml index ab430a56ad00..5463103eaebb 100644 --- a/dev-packages/node-integration-tests/suites/tracing/kafkajs/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/kafkajs/docker-compose.yml @@ -2,7 +2,6 @@ services: db: image: apache/kafka:latest restart: always - container_name: integration-tests-kafka ports: - '9092:9092' healthcheck: diff --git a/dev-packages/node-integration-tests/suites/tracing/knex/mysql2/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/knex/mysql2/docker-compose.yml index bbdc459149b7..806d7a9e1607 100644 --- a/dev-packages/node-integration-tests/suites/tracing/knex/mysql2/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/knex/mysql2/docker-compose.yml @@ -4,7 +4,6 @@ services: db_mysql2: image: mysql:8 restart: always - container_name: integration-tests-knex-mysql2 ports: - '3307:3306' environment: diff --git a/dev-packages/node-integration-tests/suites/tracing/knex/pg/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/knex/pg/docker-compose.yml index 28a916737317..c11e647ada50 100644 --- a/dev-packages/node-integration-tests/suites/tracing/knex/pg/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/knex/pg/docker-compose.yml @@ -4,7 +4,6 @@ services: db_postgres: image: postgres:13 restart: always - container_name: integration-tests-knex-postgres ports: - '5445:5432' environment: diff --git a/dev-packages/node-integration-tests/suites/tracing/mysql2-tracing-channel/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/mysql2-tracing-channel/docker-compose.yml index 216783c7731a..df7006db367d 100644 --- a/dev-packages/node-integration-tests/suites/tracing/mysql2-tracing-channel/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/mysql2-tracing-channel/docker-compose.yml @@ -2,7 +2,6 @@ services: db: image: mysql:8 restart: always - container_name: integration-tests-mysql2-dc ports: - '3308:3306' environment: diff --git a/dev-packages/node-integration-tests/suites/tracing/mysql2/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/mysql2/docker-compose.yml index 598c394ace5e..740d3a25ca80 100644 --- a/dev-packages/node-integration-tests/suites/tracing/mysql2/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/mysql2/docker-compose.yml @@ -2,7 +2,6 @@ services: db: image: mysql:8 restart: always - container_name: integration-tests-mysql ports: - '3306:3306' environment: diff --git a/dev-packages/node-integration-tests/suites/tracing/postgres-streamed/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/postgres-streamed/docker-compose.yml index c1a02da344fa..05eebd27e0f0 100644 --- a/dev-packages/node-integration-tests/suites/tracing/postgres-streamed/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/postgres-streamed/docker-compose.yml @@ -4,7 +4,6 @@ services: db: image: postgres:13 restart: always - container_name: integration-tests-postgres-streamed ports: - '5495:5432' environment: diff --git a/dev-packages/node-integration-tests/suites/tracing/postgres/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/postgres/docker-compose.yml index 44425ae56188..d9e9a66cc15a 100644 --- a/dev-packages/node-integration-tests/suites/tracing/postgres/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/postgres/docker-compose.yml @@ -4,7 +4,6 @@ services: db: image: postgres:13 restart: always - container_name: integration-tests-postgres ports: - '5494:5432' environment: diff --git a/dev-packages/node-integration-tests/suites/tracing/postgresjs/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/postgresjs/docker-compose.yml index f3afd85af9ab..4f409ec79e93 100644 --- a/dev-packages/node-integration-tests/suites/tracing/postgresjs/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/postgresjs/docker-compose.yml @@ -4,7 +4,6 @@ services: db: image: postgres:13 restart: always - container_name: integration-tests-postgresjs ports: - '5444:5432' environment: diff --git a/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v5/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v5/docker-compose.yml index 24bc212cac77..dffb4cd81ba0 100644 --- a/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v5/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v5/docker-compose.yml @@ -4,7 +4,6 @@ services: db: image: postgres:13 restart: always - container_name: integration-tests-prisma-v5 ports: - '5433:5432' environment: diff --git a/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v6/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v6/docker-compose.yml index 28f111fe3156..a8fc44deae58 100644 --- a/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v6/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v6/docker-compose.yml @@ -4,7 +4,6 @@ services: db: image: postgres:13 restart: always - container_name: integration-tests-prisma-v6 ports: - '5434:5432' environment: diff --git a/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v7/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v7/docker-compose.yml index 117b5ef2c901..d3b885122a3c 100644 --- a/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v7/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/prisma-orm-v7/docker-compose.yml @@ -4,7 +4,6 @@ services: db: image: postgres:13 restart: always - container_name: integration-tests-prisma-v7 ports: - '5435:5432' environment: diff --git a/dev-packages/node-integration-tests/suites/tracing/redis-cache/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/redis-cache/docker-compose.yml index d6381b3a4055..5d1ea8f37124 100644 --- a/dev-packages/node-integration-tests/suites/tracing/redis-cache/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/redis-cache/docker-compose.yml @@ -4,7 +4,6 @@ services: db: image: redis:latest restart: always - container_name: integration-tests-redis-cache ports: - '6383:6379' healthcheck: diff --git a/dev-packages/node-integration-tests/suites/tracing/redis-dc/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/redis-dc/docker-compose.yml index 05617e146c0d..72672cbd52f7 100644 --- a/dev-packages/node-integration-tests/suites/tracing/redis-dc/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/redis-dc/docker-compose.yml @@ -4,7 +4,6 @@ services: db: image: redis:latest restart: always - container_name: integration-tests-redis-dc ports: - '6381:6379' healthcheck: diff --git a/dev-packages/node-integration-tests/suites/tracing/redis/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/redis/docker-compose.yml index 58c4c555c2c2..f2ac9c7ad279 100644 --- a/dev-packages/node-integration-tests/suites/tracing/redis/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/redis/docker-compose.yml @@ -4,7 +4,6 @@ services: db: image: redis:latest restart: always - container_name: integration-tests-redis ports: - '6380:6379' healthcheck: diff --git a/dev-packages/node-integration-tests/suites/tracing/tedious/docker-compose.yml b/dev-packages/node-integration-tests/suites/tracing/tedious/docker-compose.yml index b77d05e2be20..ef4db33b7357 100644 --- a/dev-packages/node-integration-tests/suites/tracing/tedious/docker-compose.yml +++ b/dev-packages/node-integration-tests/suites/tracing/tedious/docker-compose.yml @@ -4,7 +4,6 @@ services: db: image: mcr.microsoft.com/mssql/server:2022-latest restart: always - container_name: integration-tests-tedious ports: - '1433:1433' environment: