Skip to content

Commit b728a5a

Browse files
msonnbcodex
andcommitted
test(e2e): Assert pageload span names in error tests
Co-Authored-By: GPT-6 <codex@openai.com>
1 parent 0f5dec5 commit b728a5a

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

dev-packages/e2e-tests/test-applications/default-browser/tests/errors.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ test('captures an error', async ({ page }) => {
2929
});
3030
});
3131

32-
test('sets correct transactionName', async ({ page }) => {
32+
test('sets the pageload span name and error transaction name', async ({ page }) => {
3333
const pageloadSpanPromise = waitForStreamedSpan('default-browser', span => {
3434
return getSpanOp(span) === 'pageload' && span.is_segment;
3535
});
@@ -40,6 +40,7 @@ test('sets correct transactionName', async ({ page }) => {
4040

4141
await page.goto('/');
4242
const pageloadSpan = await pageloadSpanPromise;
43+
expect(pageloadSpan.name).toBe('Pageload');
4344

4445
const exceptionButton = page.locator('id=exception-button');
4546
await exceptionButton.click();

dev-packages/e2e-tests/test-applications/effect-3-browser/tests/errors.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ test('captures an error', async ({ page }) => {
2828
});
2929
});
3030

31-
test('sets correct transactionName', async ({ page }) => {
31+
test('sets the pageload span name and error transaction name', async ({ page }) => {
3232
const pageloadSpanPromise = waitForStreamedSpan('effect-3-browser', span => {
3333
return getSpanOp(span) === 'pageload' && span.is_segment;
3434
});
@@ -39,6 +39,7 @@ test('sets correct transactionName', async ({ page }) => {
3939

4040
await page.goto('/');
4141
const pageloadSpan = await pageloadSpanPromise;
42+
expect(pageloadSpan.name).toBe('Pageload');
4243

4344
const exceptionButton = page.locator('id=exception-button');
4445
await exceptionButton.click();

dev-packages/e2e-tests/test-applications/effect-4-browser/tests/errors.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ test('captures an error', async ({ page }) => {
2828
});
2929
});
3030

31-
test('sets correct transactionName', async ({ page }) => {
31+
test('sets the pageload span name and error transaction name', async ({ page }) => {
3232
const pageloadSpanPromise = waitForStreamedSpan('effect-4-browser', span => {
3333
return getSpanOp(span) === 'pageload' && span.is_segment;
3434
});
@@ -39,6 +39,7 @@ test('sets correct transactionName', async ({ page }) => {
3939

4040
await page.goto('/');
4141
const pageloadSpan = await pageloadSpanPromise;
42+
expect(pageloadSpan.name).toBe('Pageload');
4243

4344
const exceptionButton = page.locator('id=exception-button');
4445
await exceptionButton.click();

0 commit comments

Comments
 (0)