Commit 6b626d2
committed
test(browser-integration): Finalize LCP with a trusted click
web-vitals finalizes LCP on the first trusted input or visibility change and checks
`isTrusted`, so the synthetic `visibilitychange` this test dispatched never finalized it. It
passed anyway while `reportAllChanges` was on, since every LCP entry was reported as it
arrived. Soft navigation reporting turns that off, so on a browser that supports the Soft
Navigations API no LCP span was emitted at all. Clicking finalizes it the way a real user does.1 parent df8b1d2 commit 6b626d2
1 file changed
Lines changed: 5 additions & 2 deletions
File tree
- dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-lcp-streamed-spans
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
34 | 37 | | |
35 | 38 | | |
36 | 39 | | |
| |||
0 commit comments