Repository navigation
Commit ae13d5b
committed
ci(store): fix an empty expression, a silent skip, and an unchecked run id
Three review findings, one of which would have stopped the workflow from
running at all.
`${{ }}` inside a `run:` block is not a comment. Actions substitutes
expressions across the whole block before the shell sees it, and an empty
one is a parse error. build.yml has the same text at line 1072 and is
fine, because there it sits in a YAML comment that never reaches the
expression parser -- the distinction is which side of `run:` it falls on.
My local YAML and shell checks could not see this: it is neither.
The job-level `if: vars.MSSTORE_PRODUCT_ID != ''` skipped the whole job
when unconfigured, and a skipped job is green and silent. build.yml can
afford that as one job in an automatic release; this one exists to be
triggered by hand, where "nothing happened, no error" is the worst
answer. MSSTORE_PRODUCT_ID moves into the configuration check and fails
loudly with a Summary line.
And an explicitly supplied run_id was trusted as given. Nothing
downstream inspects what is inside the artifact, so a transposed digit
would submit another commit's package to the Store under this tag. It is
now checked to be a build.yml run whose head_sha matches the tag being
published -- verified against the real v1.9.5 run first, so the check
accepts the run it exists to retry rather than rejecting it.
Not taken: "afterwards" -> "afterward". The repo uses "afterwards"
throughout (AGENTS.md, build-and-packaging.md, release-and-secrets.md,
manual-e2e-checklist.md, website/docs); changing one instance would make
it the odd one out.1 parent 89d58bd commit ae13d5b
1 file changed
Lines changed: 39 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | | - | |
50 | | - | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
51 | 54 | | |
52 | 55 | | |
53 | 56 | | |
| |||
63 | 66 | | |
64 | 67 | | |
65 | 68 | | |
66 | | - | |
| 69 | + | |
67 | 70 | | |
68 | 71 | | |
69 | 72 | | |
| 73 | + | |
70 | 74 | | |
71 | 75 | | |
72 | 76 | | |
73 | 77 | | |
74 | 78 | | |
75 | | - | |
76 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
77 | 85 | | |
78 | 86 | | |
79 | 87 | | |
80 | 88 | | |
81 | 89 | | |
82 | | - | |
| 90 | + | |
83 | 91 | | |
84 | 92 | | |
85 | 93 | | |
| |||
104 | 112 | | |
105 | 113 | | |
106 | 114 | | |
107 | | - | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
108 | 137 | | |
109 | 138 | | |
110 | 139 | | |
| |||
142 | 171 | | |
143 | 172 | | |
144 | 173 | | |
145 | | - | |
| 174 | + | |
| 175 | + | |
146 | 176 | | |
147 | 177 | | |
148 | 178 | | |
| |||
0 commit comments