Feature Request: a 'number of times completed' sensor

[HaniKazmi]

It'd be great to have a sensor which tracks how often a task is completed - makes it possible to graph tasks and look at trends.

With a state class of total, it'd also be able to use statistics cards to track number of times completed in a week/month etc.

I'm also happy to implement it myself and send a pull request if you're taking contributions.

[gensyn]

Sounds good, I'll give it a try. I'm leaning towards using state class total_increasing as it makes the most sense to me. Or do you have arguments for using total. Also, when do you think the sensor should increment? When pressing the button or using the service? What should happen if someone uses the service for setting the last done date? My first instinct is that setting the date should not increment the counter.

[HaniKazmi]

Thanks for the quick reply!

For my use-cases, I'd have it increment via both the button press, and via task_tracker.mark_as_done. I agree it doesn't make sense to increment with task_tracker.set_last_done_date.

My thinking around a state class of total was around this case as well - with total, task_tracker.set_last_done_date could theoretically take a parameter to decrease the count - to fix an accidental press - whereas with total_increasing that would cause the sensor to treat it as a reset.

But I don't think that's a strong reason - with total_increasing an accidental press can still be fixed by undoing the count increase in recorder as a manual step, and total_increasing probably fits better overall.