Handling process exit#1249
Merged
Merged
Conversation
sonic16x
commented
May 11, 2026
| eventsUtils.passthroughEvent(this.runner, this, _.values(MasterSyncEvents)); | ||
| eventsUtils.passthroughEventAsync(this.runner, this, _.values(MasterAsyncEvents)); | ||
| eventsUtils.passthroughEventAsync(signalHandler, this, MasterEvents.EXIT); | ||
| eventsUtils.passthroughEventAsync(signalHandler, this.runner, MasterEvents.EXIT); |
Contributor
Author
There was a problem hiding this comment.
pass exit event to runner
sonic16x
commented
May 11, 2026
Contributor
Author
There was a problem hiding this comment.
Refactoring this to typescript
sonic16x
commented
May 11, 2026
|
|
||
| let lastCallTime = 0; | ||
|
|
||
| const throttleTime = 10; |
Contributor
Author
There was a problem hiding this comment.
Throttle for SIGINT, by some reason if kill using Control + C event fired twice with delay 7-8ms, probably it is duplicates from webdriver.io
sonic16x
commented
May 11, 2026
| logger.error(`testplane:worker:${child.pid} terminated unexpectedly with ${errMsg}`); | ||
| }); | ||
|
|
||
| this.once(MasterEvents.EXIT, () => child.kill()); |
Contributor
Author
There was a problem hiding this comment.
Kill child process if get EXIT event from master (through runner)
sonic16x
commented
May 11, 2026
| this.workers = this.registerWorkers(require.resolve("../worker"), ["runTest", "cancel"] as const) as Workers; | ||
| this.browserPool = pool.create(this.config, this); | ||
|
|
||
| eventsUtils.passthroughEvent(this, this.workersRegistry, MasterEvents.EXIT); |
Contributor
Author
There was a problem hiding this comment.
Pass event to childs
sonic16x
commented
May 11, 2026
| this._emit(MasterEvents.TEST_PASS); | ||
| } catch (error) { | ||
| this._test.err = error; | ||
| this._test.err = this._browser.exitError || error; |
Contributor
Author
There was a problem hiding this comment.
Use exit error if exist
sonic16x
commented
May 11, 2026
| super(config, opts); | ||
|
|
||
| signalHandler.on("exit", () => this.quit()); | ||
| signalHandler.on("exit", (err?: Error) => this.quit(err)); |
Contributor
Author
There was a problem hiding this comment.
pass error from exit event
sonic16x
commented
May 11, 2026
|
|
||
| async quit(): Promise<void> { | ||
| async quit(err?: Error): Promise<void> { | ||
| this._exitError = err; |
Contributor
Author
There was a problem hiding this comment.
save in browser for using in test fail
sonic16x
force-pushed
the
handling-process-exit
branch
2 times, most recently
from
395f2fa to
8a45901
Compare
sonic16x
commented
May 11, 2026
Contributor
Author
There was a problem hiding this comment.
Refactor to typescript
sonic16x
commented
May 11, 2026
Contributor
Author
There was a problem hiding this comment.
Refactor to typescript
commit: |
KuznetsovRoman
approved these changes
May 20, 2026
sonic16x
force-pushed
the
handling-process-exit
branch
from
8a45901 to
a43afe3
Compare
sonic16x
force-pushed
the
handling-process-exit
branch
from
a43afe3 to
cf425ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fail current running test with specific error before process exit
