From 4baee02f7d0fe0c9a4086b0374d12467ebac7edb Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Sun, 15 Feb 2026 12:50:17 +0000
Subject: [PATCH] refactor: rename DEFAULT_LOCAL_URL to EMPTY_BASE_URL

Renamed the constant DEFAULT_LOCAL_URL to EMPTY_BASE_URL in src/core/constants.ts and updated all its references. This change improves code readability as the name now more accurately reflects the value ('') and its purpose as an unconfigured URL indicator.

- Updated src/core/constants.ts
- Updated src/providers/local/index.ts
- Updated src/core/config.ts
- Updated src/test/integration/config.test.ts

Co-authored-by: gasatrya <891643+gasatrya@users.noreply.github.com>
---
 src/core/config.ts                  | 4 ++--
 src/core/constants.ts               | 2 +-
 src/providers/local/index.ts        | 6 +++---
 src/test/integration/config.test.ts | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/core/config.ts b/src/core/config.ts
index b566702..8374626 100644
--- a/src/core/config.ts
+++ b/src/core/config.ts
@@ -1,6 +1,6 @@
 import * as vscode from 'vscode';
 import { PredicteCommitConfig } from './types';
-import { DEFAULT_LOCAL_URL } from './constants';
+import { EMPTY_BASE_URL } from './constants';
 
 export function getConfig(): PredicteCommitConfig {
   const cfg = vscode.workspace.getConfiguration('predicteCommit');
@@ -12,7 +12,7 @@ export function getConfig(): PredicteCommitConfig {
     ignoredFiles: cfg.get<string[]>('ignoredFiles', ['*-lock.json', '*.svg', 'dist/**']),
     useLocal,
     localProvider: cfg.get<string>('localProvider', 'ollama'),
-    localBaseUrl: cfg.get<string>('localBaseUrl', DEFAULT_LOCAL_URL),
+    localBaseUrl: cfg.get<string>('localBaseUrl', EMPTY_BASE_URL),
     localModel: cfg.get<string>('localModel', ''),
     debugLogging: cfg.get<boolean>('debugLogging', false),
   };
diff --git a/src/core/constants.ts b/src/core/constants.ts
index 7e65d52..83d47c1 100644
--- a/src/core/constants.ts
+++ b/src/core/constants.ts
@@ -1,4 +1,4 @@
-export const DEFAULT_LOCAL_URL = '';
+export const EMPTY_BASE_URL = '';
 
 export const DIFF_CAPS: { maxCharsPerFile: number; maxCharsTotal: number } = {
   maxCharsPerFile: 8000,
diff --git a/src/providers/local/index.ts b/src/providers/local/index.ts
index 9037803..ecc258b 100644
--- a/src/providers/local/index.ts
+++ b/src/providers/local/index.ts
@@ -1,7 +1,7 @@
 import { postChatCompletion } from '../../ai/http';
 import type { GenerateRequest, GenerateResult, ProviderClient } from '../../ai/types';
 import { registerProvider } from '../../ai/registry';
-import { DEFAULT_LOCAL_URL } from '../../core/constants';
+import { EMPTY_BASE_URL } from '../../core/constants';
 
 export class LocalProvider implements ProviderClient {
   constructor(
@@ -29,8 +29,8 @@ const createLocalProvider = (id: string, defaultUrl: string) => {
     // If the user hasn't changed the URL (it's empty),
     // then use that provider's default.
     // Otherwise (user changed it), use what's in config.
-    if (baseUrl === DEFAULT_LOCAL_URL) {
-      // DEFAULT_LOCAL_URL is ''
+    if (baseUrl === EMPTY_BASE_URL) {
+      // EMPTY_BASE_URL is ''
       baseUrl = defaultUrl;
     }
 
diff --git a/src/test/integration/config.test.ts b/src/test/integration/config.test.ts
index 26c268a..a724dea 100644
--- a/src/test/integration/config.test.ts
+++ b/src/test/integration/config.test.ts
@@ -2,7 +2,7 @@ import * as assert from 'assert';
 import { getConfig } from '../../core/config';
 import { PredicteCommitConfig } from '../../core/types';
 import { getEffectiveProviderId } from '../../core/logic';
-import { DEFAULT_LOCAL_URL } from '../../core/constants';
+import { EMPTY_BASE_URL } from '../../core/constants';
 
 suite('Config Test Suite', () => {
   test('getEffectiveProviderId', () => {
@@ -52,7 +52,7 @@ suite('Config Test Suite', () => {
     assert.strictEqual(cfg.useLocal, false);
     assert.strictEqual(cfg.localProvider, 'ollama');
     assert.deepStrictEqual(cfg.ignoredFiles, ['*-lock.json', '*.svg', 'dist/**']);
-    assert.strictEqual(cfg.localBaseUrl, DEFAULT_LOCAL_URL);
+    assert.strictEqual(cfg.localBaseUrl, EMPTY_BASE_URL);
     assert.strictEqual(cfg.localModel, '');
   });
 });