Possible bug in TOmniValueQueue

[TommiPrami]

No idea if I can make reproducible case out of this, most likely not, but I have situation when I put stuff in the Queue, canel the multithreaded process.

TOmniValueQueue.Destroy gets called, on FreeAndNil(FInnerQueue);

calls to the TOmniValueQueue.CollectionNotifyEvent starts firing, and the FInnerQueue is freed in this point.

made following change to the procedure

procedure TOmniValueQueue.CollectionNotifyEvent(Sender: TObject;
  const Item: TOmniValue; Action: TCollectionNotification);
var
  AfterCount: integer;
begin
  // This method occurs within the critical section.
  AfterCount := -1; // <- Change starts 
  if Assigned(FInnerQueue) then
    AfterCount := FInnerQueue.Count; // <- Change ends

Maybe this should be handled earlier, or ion completely other way, in TOmniValueQueue or in my code. but it seems that this will get rid of Access Violation, or the destructor TOmniValueQueue.Destroy; should firs clear the Queue, before releasing FInnerQueue

[TommiPrami]

I've added in my code following code:

var LValue: TOmniValue;
while LFiles.TryDequeue(LValue) do

So I'll make sure the queue is empty before continuing, so it takes care of this also.

I would think that the proper fix would be to add similar code into the

TOmniValueQueue.Destroy;

Seems weird that user code has to clear the queue to avoid Access Violation.

[TommiPrami]

Also public Clear -method could be nice to have...