fix: Fixed cross-platform issues (#18)

* fix: Fixed cross-platform issues

* code review fixes

Author: gallayl

.yarn/changelogs/frontend.b4e99528.md

@@ -0,0 +1,6 @@
+<!-- version-type: patch -->
+# frontend
+
+## 🧪 Tests
+
+- Replaced hard-coded `/tmp/...` paths in the payload-validator specs (`stack-form.spec.ts`, `import-stack.spec.ts`) with `os.tmpdir()`-based equivalents so the frontend `vitest` suite runs unmodified on Windows hosts (where `/tmp` does not exist) in addition to Linux and macOS.

.yarn/changelogs/service.b4e99528.md

@@ -0,0 +1,17 @@
+<!-- version-type: patch -->
+# service
+
+## 🐛 Bug Fixes
+
+### Yarn prerequisite check now resolves on Windows
+
+`checkYarn` previously called `execFile('yarn', ['--version'])`, which fails on Windows because Yarn is installed as a `yarn.cmd` / `yarn.ps1` shim — `execFile` does not consult `PATHEXT` and therefore reports the prerequisite as "not matched". On Windows the call is now routed through `cmd.exe /c yarn --version` so the shim is resolved like it is in any interactive shell. POSIX still uses `execFile` directly.
+
+### Graceful service shutdown on Windows
+
+`ProcessRunner.killProcessGroup` always invoked `taskkill /pid … /T /F` on Windows, regardless of the requested signal. Because `/F` is an unconditional force-kill, the SIGTERM-then-wait-then-SIGKILL escalation in `ServiceLifecycleManager` collapsed into a single force kill — managed services never received a chance to flush state on shutdown. The Windows branch now drops `/F` for non-`SIGKILL` signals and reserves it for `SIGKILL`, restoring the graceful-then-force escalation that POSIX already had.
+
+## 🧪 Tests
+
+- Added a Windows-specific `killProcessGroup` spec asserting `taskkill` is invoked **without** `/F` for `SIGTERM` and **with** `/F` for `SIGKILL`.
+- Replaced hard-coded `/tmp/...` literals in service specs with `os.tmpdir()`-based paths (`join(tmpdir(), '...')`) so spec runs are portable across Linux, macOS, and Windows. Affected specs: `git-operations-service`, `git-watcher`, `git-head-watcher`, `service-delete-branch-action`, `import-export-actions`, `create-stack-action`, `service-branches-action`, `resolve-service-cwd`, `encrypt-existing-secrets`, `service-pipeline-orchestrator`, `service-env-resolver`, `stale-state-reconciler`, `service-file-manager`, `service-checkout-action`, `check-prerequisite-action`, `evaluate-prerequisites`. The two `/tmp` references that remain in `process-runner.spec.ts` are intentional — they pair with explicit `process.platform = 'linux'` mocks that exercise the POSIX `'/bin/sh'` branch.

.yarn/changelogs/stack-craft.b4e99528.md

@@ -0,0 +1,6 @@
+<!-- version-type: patch -->
+# stack-craft
+
+## 🧪 Tests
+
+- Replaced hard-coded `/tmp/...` paths in Playwright E2E specs (`e2e/smoke.spec.ts`, `e2e/dogfooding.spec.ts`) and the frontend payload-validator specs (`stack-form.spec.ts`, `import-stack.spec.ts`) with `os.tmpdir()`-based paths so the suite runs unmodified on Windows hosts (where `/tmp` does not exist) in addition to Linux and macOS.

.yarn/versions/b4e99528.yml

@@ -0,0 +1,4 @@
+releases:
+  frontend: patch
+  service: patch
+  stack-craft: patch

e2e/dogfooding.spec.ts

@@ -1,4 +1,6 @@
 import { randomBytes } from 'crypto'
+import { tmpdir } from 'os'
+import { join } from 'path'
 
 import { expect, test } from '@playwright/test'
 
@@ -48,7 +50,7 @@ It is used to test the following features:
 
   const dogfoodingPort = await getAvailablePort()
   const mcpPort = await getAvailablePort()
-  const workingDirectory = `/tmp/e2e-dog-fooding-time-${uuid}`
+  const workingDirectory = join(tmpdir(), `e2e-dog-fooding-time-${uuid}`)
 
   await page.goto('/')
   await login(page)
@@ -59,7 +61,7 @@ It is used to test the following features:
         name: stackName,
         displayName,
         description,
-        mainDirectory: '/tmp/e2e-test',
+        mainDirectory: join(tmpdir(), 'e2e-test'),
       })
     })
 

e2e/smoke.spec.ts

@@ -1,4 +1,6 @@
 import { expect, test } from '@playwright/test'
+import { tmpdir } from 'os'
+import { join } from 'path'
 
 import {
   addRepository,
@@ -15,7 +17,7 @@ test('App Flow', async ({ page, browserName }) => {
 
   const stackName = `e2e-test-stack-${uuid}`
   const displayName = `E2E Test Stack - ${browserName} - ${uuid}`
-  const workingDirectory = `/tmp/e2e-test-stack-${uuid}`
+  const workingDirectory = join(tmpdir(), `e2e-test-stack-${uuid}`)
 
   await page.goto('/')
   await login(page)
@@ -26,7 +28,7 @@ test('App Flow', async ({ page, browserName }) => {
         name: stackName,
         displayName,
         description: 'Created by E2E test',
-        mainDirectory: '/tmp/e2e-test',
+        mainDirectory: join(tmpdir(), 'e2e-test'),
       })
     })
 

frontend/src/components/entity-forms/stack-form.spec.ts

@@ -1,9 +1,12 @@
+import { tmpdir } from 'os'
 import { describe, expect, it, vi } from 'vitest'
 
 vi.mock('../app-routes.js', () => ({}))
 
 import { isStackFormPayload } from './stack-form.js'
 
+const TMP = tmpdir()
+
 describe('isStackFormPayload', () => {
   const validPayload = {
     name: 'my-stack',
@@ -17,7 +20,7 @@ describe('isStackFormPayload', () => {
   })
 
   it('should accept payload without description (not validated)', () => {
-    expect(isStackFormPayload({ name: 'x', displayName: 'X', mainDirectory: '/tmp' })).toBe(true)
+    expect(isStackFormPayload({ name: 'x', displayName: 'X', mainDirectory: TMP })).toBe(true)
   })
 
   it('should throw on null (no null guard)', () => {
@@ -29,15 +32,15 @@ describe('isStackFormPayload', () => {
   })
 
   it('should reject when name is missing', () => {
-    expect(isStackFormPayload({ displayName: 'X', mainDirectory: '/tmp' })).toBe(false)
+    expect(isStackFormPayload({ displayName: 'X', mainDirectory: TMP })).toBe(false)
   })
 
   it('should reject when name is empty', () => {
     expect(isStackFormPayload({ ...validPayload, name: '' })).toBe(false)
   })
 
   it('should reject when displayName is missing', () => {
-    expect(isStackFormPayload({ name: 'x', mainDirectory: '/tmp' })).toBe(false)
+    expect(isStackFormPayload({ name: 'x', mainDirectory: TMP })).toBe(false)
   })
 
   it('should reject when displayName is empty', () => {

frontend/src/pages/import-export/import-stack.spec.ts

@@ -1,3 +1,5 @@
+import { tmpdir } from 'os'
+import { join } from 'path'
 import { describe, expect, it, vi } from 'vitest'
 
 vi.mock('../../components/app-routes.js', () => ({}))
@@ -12,7 +14,7 @@ describe('isImportConfigPayload', () => {
   it('should accept payload with additional env fields', () => {
     expect(
       isImportConfigPayload({
-        mainDirectory: '/tmp/stack',
+        mainDirectory: join(tmpdir(), 'stack'),
         autoSetup: 'on',
         envSource_GITHUB_TOKEN: 'inherit',
         envValue_GITHUB_TOKEN: '',

service/src/app-models/prerequisites/actions/check-prerequisite-action.spec.ts

@@ -6,6 +6,7 @@ import { usingAsync } from '@furystack/utils'
 import { Prerequisite, PrerequisiteCheckResult, StackConfig } from 'common'
 import type { PrerequisiteType } from 'common'
 import { randomBytes } from 'crypto'
+import { tmpdir } from 'os'
 import { describe, expect, it, vi } from 'vitest'
 
 import { runCheck, CheckPrerequisiteAction } from './check-prerequisite-action.js'
@@ -89,6 +90,36 @@ describe('CheckPrerequisiteAction', () => {
         const result = await runCheck('yarn', { minimumVersion: '4.0.0' })
         expect(result.satisfied).toBe(false)
       })
+
+      it('should invoke `yarn --version` directly on POSIX', async () => {
+        const originalPlatform = process.platform
+        Object.defineProperty(process, 'platform', { value: 'linux', writable: true })
+        try {
+          execFileMock.mockResolvedValue({ stdout: '4.6.0\n', stderr: '' })
+          await runCheck('yarn', { minimumVersion: '4.0.0' })
+          expect(execFileMock).toHaveBeenCalledWith('yarn', ['--version'], expect.objectContaining({ timeout: 30_000 }))
+        } finally {
+          Object.defineProperty(process, 'platform', { value: originalPlatform, writable: true })
+        }
+      })
+
+      // Yarn ships as `yarn.cmd` / `yarn.ps1` on Windows; routing through `cmd.exe`
+      // is the load-bearing fix that lets PATHEXT resolve the shim. Guard against regression.
+      it('should route through cmd.exe on Windows to resolve the yarn shim', async () => {
+        const originalPlatform = process.platform
+        Object.defineProperty(process, 'platform', { value: 'win32', writable: true })
+        try {
+          execFileMock.mockResolvedValue({ stdout: '4.6.0\n', stderr: '' })
+          await runCheck('yarn', { minimumVersion: '4.0.0' })
+          expect(execFileMock).toHaveBeenCalledWith(
+            'cmd.exe',
+            ['/c', 'yarn', '--version'],
+            expect.objectContaining({ timeout: 30_000 }),
+          )
+        } finally {
+          Object.defineProperty(process, 'platform', { value: originalPlatform, writable: true })
+        }
+      })
     })
 
     describe('git', () => {
@@ -264,7 +295,7 @@ describe('CheckPrerequisiteAction', () => {
         })
         await stackConfigStore.add({
           stackName: 'test-stack',
-          mainDirectory: '/tmp',
+          mainDirectory: tmpdir(),
           environmentVariables: {
             STACK_CONFIGURED_VAR_12345: { source: 'custom', customValue: 'configured-value' },
           },

service/src/app-models/prerequisites/actions/check-prerequisite-action.ts

@@ -57,7 +57,12 @@ const checkNode = async (config: { minimumVersion: string }): Promise<CheckResul
 }
 
 const checkYarn = async (config: { minimumVersion: string }): Promise<CheckResult> => {
-  const { stdout } = await execFileAsync('yarn', ['--version'], { timeout: COMMAND_TIMEOUT })
+  // Yarn ships as `yarn.cmd` / `yarn.ps1` shims on Windows, which `execFile` cannot resolve directly.
+  // Route through cmd.exe so PATHEXT applies. POSIX uses execFile directly to avoid an extra fork.
+  const isWindows = process.platform === 'win32'
+  const { stdout } = isWindows
+    ? await execFileAsync('cmd.exe', ['/c', 'yarn', '--version'], { timeout: COMMAND_TIMEOUT })
+    : await execFileAsync('yarn', ['--version'], { timeout: COMMAND_TIMEOUT })
   const version = extractVersion(stdout.trim())
   if (!version) {
     return { satisfied: false, output: `Could not parse Yarn version from: ${stdout.trim()}` }