test: live coverage for the Predict families, and an exact trigger match

Read-only live tests for change sets, diffs, webhooks and configuration,
each skipping rather than failing on an instance with nothing to read,
so the weekly backstop watches these shapes too. All 23 pass against the
local build with writes, and 21 pass against a second Predict-enabled
instance with the rest skipped.

That second instance found a test bug worth naming. Its newest
predictions were unprocessed, which Forward refuses with 409 and the
documented SNAPSHOT_UNAVAILABLE reason, correctly. The test's fix was to
pick a processed prediction, and the first attempt at that used a suffix
match on the state, which is wrong for a reason that reads like a joke:
"UNPROCESSED" ends with "PROCESSED". The same idiom was in the SDK's
own predicted-snapshot check, harmless there because no trigger name
ends in PREDICT other than PREDICT, but it is now an exact match on the
value so it cannot become harmful when a name is added.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019Kbxab7ihjPntGAmnsZtqG

Author: captainpacket

src/forward_sdk/_async/services/snapshots.py

@@ -77,7 +77,12 @@ def __repr__(self) -> str:  # pragma: no cover - debugging aid
 def is_predicted(snapshot: SnapshotInfo) -> bool:
     """Whether Forward made this snapshot to analyse a change set."""
     trigger = getattr(snapshot, "processing_trigger", None)
-    return trigger is not None and str(trigger).upper().endswith(PREDICT_TRIGGER)
+    if trigger is None:
+        return False
+    # Exact match on the value. A suffix test would be wrong for the same
+    # reason "UNPROCESSED" ends with "PROCESSED".
+    value = getattr(trigger, "value", trigger)
+    return str(value).upper() == PREDICT_TRIGGER
 
 
 def _state_of(snapshot: SnapshotInfo) -> str:

src/forward_sdk/_sync/services/snapshots.py

@@ -79,7 +79,12 @@ def __repr__(self) -> str:  # pragma: no cover - debugging aid
 def is_predicted(snapshot: SnapshotInfo) -> bool:
     """Whether Forward made this snapshot to analyse a change set."""
     trigger = getattr(snapshot, "processing_trigger", None)
-    return trigger is not None and str(trigger).upper().endswith(PREDICT_TRIGGER)
+    if trigger is None:
+        return False
+    # Exact match on the value. A suffix test would be wrong for the same
+    # reason "UNPROCESSED" ends with "PROCESSED".
+    value = getattr(trigger, "value", trigger)
+    return str(value).upper() == PREDICT_TRIGGER
 
 
 def _state_of(snapshot: SnapshotInfo) -> str:

tests/live/test_live.py

@@ -244,13 +244,24 @@ def test_change_set_summary_and_commits(self, client: ForwardClient, network_id:
     def test_diffs_between_a_base_and_its_prediction(
         self, client: ForwardClient, network_id: str
     ) -> None:
-        candidates = [cs for cs in client.change_sets.list(network_id) if cs.predicted_snapshots]
-        if not candidates:
-            pytest.skip("no change set has a predicted snapshot")
-        base = candidates[0].snapshot_id
-        predicted = candidates[0].predicted_snapshots or []
-        after = predicted[0].id if predicted else None
-        assert base and after
+        # A prediction that has not finished processing is refused with 409
+        # SNAPSHOT_UNAVAILABLE, correctly, so pick one that has. Compare the
+        # state exactly: "UNPROCESSED" ends with "PROCESSED".
+        base = after = None
+        for info in client.change_sets.list(network_id):
+            if not info.predicted_snapshots or not info.id:
+                continue
+            handle = client.change_sets.handle(info.id, network_id=network_id)
+            processed = [
+                snap
+                for snap in handle.predicted_snapshots()
+                if str(snap.state) == "PROCESSED" and snap.id
+            ]
+            if processed:
+                base, after = info.snapshot_id, processed[0].id
+                break
+        if not (base and after):
+            pytest.skip("no change set has a processed predicted snapshot")
         diffs = client.snapshot_diffs
         connectivity = diffs.wait_for_subnet_connectivity(base, after, timeout=300)
         assert not connectivity.is_partial_result