From e648757316e134dea0801e8f683e160cb5cd68bb Mon Sep 17 00:00:00 2001 From: Aurora <3797723137@qq.com> Date: Sun, 6 Sep 2026 20:00:45 +0800 Subject: [PATCH 1/3] Fix unreachable code warning in range formatter --- include/fmt/ranges.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/fmt/ranges.h b/include/fmt/ranges.h index 99bef84173aa..1131ccabd452 100644 --- a/include/fmt/ranges.h +++ b/include/fmt/ranges.h @@ -515,10 +515,9 @@ struct formatter< using nonlocking = void; FMT_CONSTEXPR formatter() { - if FMT_CONSTEXPR20 (range_format_kind::value != range_format::set) - return; - range_formatter_.set_brackets(detail::string_literal{}, - detail::string_literal{}); + if FMT_CONSTEXPR20 (range_format_kind::value == range_format::set) + range_formatter_.set_brackets(detail::string_literal{}, + detail::string_literal{}); } FMT_CONSTEXPR auto parse(parse_context& ctx) -> const Char* { From af21761b8823900141998118f4d5728f14a13e4a Mon Sep 17 00:00:00 2001 From: zhao0335 <3797723137@qq.com> Date: Mon, 14 Sep 2026 00:15:28 +0800 Subject: [PATCH 2/3] Add braces around range formatter condition --- include/fmt/ranges.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/fmt/ranges.h b/include/fmt/ranges.h index 1131ccabd452..dc4e860409af 100644 --- a/include/fmt/ranges.h +++ b/include/fmt/ranges.h @@ -515,9 +515,10 @@ struct formatter< using nonlocking = void; FMT_CONSTEXPR formatter() { - if FMT_CONSTEXPR20 (range_format_kind::value == range_format::set) + if FMT_CONSTEXPR20 (range_format_kind::value == range_format::set) { range_formatter_.set_brackets(detail::string_literal{}, detail::string_literal{}); + } } FMT_CONSTEXPR auto parse(parse_context& ctx) -> const Char* { From e949303f839c59e2f5b9580654b77d41601d6b77 Mon Sep 17 00:00:00 2001 From: zhao0335 <3797723137@qq.com> Date: Mon, 14 Sep 2026 21:38:37 +0800 Subject: [PATCH 3/3] style: wrap range formatter condition to satisfy clang-format --- include/fmt/ranges.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/fmt/ranges.h b/include/fmt/ranges.h index dc4e860409af..9b955d9b4f16 100644 --- a/include/fmt/ranges.h +++ b/include/fmt/ranges.h @@ -515,7 +515,8 @@ struct formatter< using nonlocking = void; FMT_CONSTEXPR formatter() { - if FMT_CONSTEXPR20 (range_format_kind::value == range_format::set) { + if FMT_CONSTEXPR20 (range_format_kind::value == + range_format::set) { range_formatter_.set_brackets(detail::string_literal{}, detail::string_literal{}); }