From 52f096b6b92e207fa70312c57017bcdb08d892a2 Mon Sep 17 00:00:00 2001 From: mccakit Date: Wed, 18 Mar 2026 21:57:53 +0300 Subject: [PATCH 1/3] clang compilation failiure fix --- src/fmt.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/fmt.cc b/src/fmt.cc index 0713da75c393..1973a1ac9d23 100644 --- a/src/fmt.cc +++ b/src/fmt.cc @@ -134,11 +134,6 @@ extern "C++" { } #endif -// gcc doesn't yet implement private module fragments -#if !FMT_GCC_VERSION -module :private; -#endif - #ifdef FMT_ATTACH_TO_GLOBAL_MODULE extern "C++" { #endif From 9ffbbed10c450af1b2c9018f5a68fb4b761f7b8e Mon Sep 17 00:00:00 2001 From: mccakit <117523238+mccakit@users.noreply.github.com> Date: Tue, 21 Jul 2026 16:50:23 +0300 Subject: [PATCH 2/3] lint fix --- include/fmt/base.h | 12 +++++++----- include/fmt/fmt-c.h | 11 ++++++----- include/fmt/format.h | 4 ++-- 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/include/fmt/base.h b/include/fmt/base.h index 70f18c23271c..48adb7941955 100644 --- a/include/fmt/base.h +++ b/include/fmt/base.h @@ -1010,14 +1010,14 @@ constexpr auto in(type t, int set) -> bool { // Bitsets of types. enum { - sint_set = - set(type::int_type) | set(type::long_long_type) | set(type::int128_type), + sint_set = set(type::int_type) | set(type::long_long_type) | + set(type::int128_type), uint_set = set(type::uint_type) | set(type::ulong_long_type) | - set(type::uint128_type), + set(type::uint128_type), bool_set = set(type::bool_type), char_set = set(type::char_type), float_set = set(type::float_type) | set(type::double_type) | - set(type::long_double_type), + set(type::long_double_type), string_set = set(type::string_type), cstring_set = set(type::cstring_type), pointer_set = set(type::pointer_type) @@ -2616,7 +2616,9 @@ template struct runtime_format_string { * // Check format string at runtime instead of compile-time. * fmt::print(fmt::runtime("{:d}"), "I am not a number"); */ -inline auto runtime(string_view s) -> runtime_format_string<> { return {{s}}; } +inline auto runtime(string_view s) -> runtime_format_string<> { + return {{s}}; +} /// A compile-time format string. Use `format_string` in the public API to /// prevent type deduction. diff --git a/include/fmt/fmt-c.h b/include/fmt/fmt-c.h index ce878fdc8961..1ce41d3781dd 100644 --- a/include/fmt/fmt-c.h +++ b/include/fmt/fmt-c.h @@ -181,11 +181,12 @@ typedef enum {} fmt_signed_char; (fmt_arg[]) { FMT_MAP(FMT_MAKE_ARG, ##__VA_ARGS__) } # define FMT_EXPAND(v) v -# define fmt_format(buffer, size, fmt, ...) \ - fmt_vformat((buffer), (size), (fmt), \ - FMT_EXPAND(FMT_VA_SELECT(FMT_MAKE_NULL, FMT_MAKE_ARGLIST, \ - ##__VA_ARGS__)(__VA_ARGS__)), \ - FMT_NARG(, ##__VA_ARGS__)) +# define fmt_format(buffer, size, fmt, ...) \ + fmt_vformat( \ + (buffer), (size), (fmt), \ + FMT_EXPAND(FMT_VA_SELECT( \ + FMT_MAKE_NULL, FMT_MAKE_ARGLIST, ##__VA_ARGS__)(__VA_ARGS__)), \ + FMT_NARG(, ##__VA_ARGS__)) #endif // __cplusplus diff --git a/include/fmt/format.h b/include/fmt/format.h index b358f0425fa2..c9b95dbd5f02 100644 --- a/include/fmt/format.h +++ b/include/fmt/format.h @@ -2021,7 +2021,7 @@ auto write_int(OutputIt out, UInt value, unsigned prefix, int num_digits = 0; auto buffer = memory_buffer(); switch (specs.type()) { - default: FMT_ASSERT(false, ""); FMT_FALLTHROUGH; + default: FMT_ASSERT(false, ""); FMT_FALLTHROUGH; case presentation_type::none: case presentation_type::dec: num_digits = count_digits(value); @@ -2150,7 +2150,7 @@ FMT_CONSTEXPR FMT_INLINE auto write_int(OutputIt out, write_int_arg arg, auto abs_value = arg.abs_value; auto prefix = arg.prefix; switch (specs.type()) { - default: FMT_ASSERT(false, ""); FMT_FALLTHROUGH; + default: FMT_ASSERT(false, ""); FMT_FALLTHROUGH; case presentation_type::none: case presentation_type::dec: begin = do_format_decimal(buffer, abs_value, buffer_size); From 827f66d49c611a0489df4af78a1efdbfd601a089 Mon Sep 17 00:00:00 2001 From: mccakit <117523238+mccakit@users.noreply.github.com> Date: Tue, 21 Jul 2026 17:00:18 +0300 Subject: [PATCH 3/3] lint fixes 2 --- include/fmt/fmt-c.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/fmt/fmt-c.h b/include/fmt/fmt-c.h index 3f8714d41677..1c3d2388823f 100644 --- a/include/fmt/fmt-c.h +++ b/include/fmt/fmt-c.h @@ -201,10 +201,10 @@ typedef enum {} fmt_signed_char; (fmt_arg[]) { FMT_MAP(FMT_MAKE_ARG, ##__VA_ARGS__) } # define FMT_EXPAND(v) v -# define FMT_FORMAT_ARGS(fmt, ...) \ - (fmt), \ - FMT_EXPAND(FMT_VA_SELECT(FMT_MAKE_NULL, FMT_MAKE_ARGLIST, \ - ##__VA_ARGS__)(__VA_ARGS__)), \ +# define FMT_FORMAT_ARGS(fmt, ...) \ + (fmt), \ + FMT_EXPAND(FMT_VA_SELECT( \ + FMT_MAKE_NULL, FMT_MAKE_ARGLIST, ##__VA_ARGS__)(__VA_ARGS__)), \ FMT_NARG(, ##__VA_ARGS__) # define fmt_format(buffer, size, fmt, ...) \