make formatter happy.

Author: taeold

src/firebase_functions/dataconnect_fn.py

@@ -208,7 +208,9 @@ def _dataconnect_endpoint_handler(
 ) -> None:
     # Currently, only mutationExecuted is supported
     if event_type != _event_type_mutation_executed:
-        raise NotImplementedError(f"Unsupported event type: {event_type}. Only {_event_type_mutation_executed} is currently supported.")
+        raise NotImplementedError(
+            f"Unsupported event type: {event_type}. Only {_event_type_mutation_executed} is currently supported."
+        )
 
     event_attributes = raw._get_attributes()
     event_data: _typing.Any = raw.get_data()
@@ -223,15 +225,9 @@ def _dataconnect_endpoint_handler(
     if service_pattern:
         params = {**params, **service_pattern.extract_matches(event_service)}
     if connector_pattern:
-        params = {
-            **params,
-            **connector_pattern.extract_matches(event_connector)
-        }
+        params = {**params, **connector_pattern.extract_matches(event_connector)}
     if operation_pattern:
-        params = {
-            **params,
-            **operation_pattern.extract_matches(event_operation)
-        }
+        params = {**params, **operation_pattern.extract_matches(event_operation)}
 
     event_auth_type = event_attributes["authtype"]
     event_auth_id = event_attributes["authid"]
@@ -281,12 +277,13 @@ def mutation_executed_handler(event: Event[MutationEventData]):
     options = DataConnectOptions(**kwargs)
 
     def on_mutation_executed_inner_decorator(func: _C1):
-        service_pattern = _path_pattern.PathPattern(
-            options.service) if options.service else None
-        connector_pattern = _path_pattern.PathPattern(
-            options.connector) if options.connector else None
-        operation_pattern = _path_pattern.PathPattern(
-            options.operation) if options.operation else None
+        service_pattern = _path_pattern.PathPattern(options.service) if options.service else None
+        connector_pattern = (
+            _path_pattern.PathPattern(options.connector) if options.connector else None
+        )
+        operation_pattern = (
+            _path_pattern.PathPattern(options.operation) if options.operation else None
+        )
 
         @_functools.wraps(func)
         def on_mutation_executed_wrapped(raw: _ce.CloudEvent):

src/firebase_functions/options.py

@@ -1188,22 +1188,22 @@ def _endpoint(
         event_filters_path_patterns: _typing.Any = {}
 
         if self.service:
-          if service_pattern.has_wildcards:
-              event_filters_path_patterns["service"] = service_pattern.value
-          else:
-              event_filters["service"] = service_pattern.value
+            if service_pattern.has_wildcards:
+                event_filters_path_patterns["service"] = service_pattern.value
+            else:
+                event_filters["service"] = service_pattern.value
 
         if self.connector:
-          if connector_pattern.has_wildcards:
-              event_filters_path_patterns["connector"] = connector_pattern.value
-          else:
-              event_filters["connector"] = connector_pattern.value
+            if connector_pattern.has_wildcards:
+                event_filters_path_patterns["connector"] = connector_pattern.value
+            else:
+                event_filters["connector"] = connector_pattern.value
 
         if self.operation:
-          if operation_pattern.has_wildcards:
-              event_filters_path_patterns["operation"] = operation_pattern.value
-          else:
-              event_filters["operation"] = operation_pattern.value
+            if operation_pattern.has_wildcards:
+                event_filters_path_patterns["operation"] = operation_pattern.value
+            else:
+                event_filters["operation"] = operation_pattern.value
 
         event_trigger = _manifest.EventTrigger(
             eventType=kwargs["event_type"],

tests/repro_async_error.py

@@ -0,0 +1,48 @@
+import json
+
+import pytest
+from flask import Request, Response
+
+from firebase_functions import https_fn
+
+
+# Mock request object
+class MockRequest:
+    def __init__(self, data=None, headers=None, method="POST"):
+        self.data = json.dumps(data).encode("utf-8") if data else b""
+        self.headers = headers or {"Content-Type": "application/json"}
+        self.method = method
+        self.json = data
+
+
+# Async function with error
+@https_fn.on_request()
+async def async_error_func(req: Request) -> Response:
+    raise ValueError("Async error")
+
+
+# Sync function with error
+@https_fn.on_request()
+def sync_error_func(req: Request) -> Response:
+    raise ValueError("Sync error")
+
+
+@pytest.mark.asyncio
+async def test_async_error_handling():
+    req = MockRequest()
+    try:
+        await async_error_func(req)
+    except ValueError as e:
+        assert str(e) == "Async error"
+    except Exception as e:
+        pytest.fail(f"Unexpected exception: {type(e).__name__}: {e}")
+
+
+def test_sync_error_handling():
+    req = MockRequest()
+    try:
+        sync_error_func(req)
+    except ValueError as e:
+        assert str(e) == "Sync error"
+    except Exception as e:
+        pytest.fail(f"Unexpected exception: {type(e).__name__}: {e}")

tests/test_dataconnect_fn.py

@@ -132,7 +132,7 @@ def init():
                 "connector": "connector-id",
                 "operation": "mutation-name",
                 "authtype": "app_user",
-                "authid": "auth-id"
+                "authid": "auth-id",
             },
             data=json.dumps({}),
         )