This repo has no ci.yml. The workflows present are deb.yml, publish-crate.yml, and release.yml, all tag-triggered, so a pull request gets no build, no test run, no cargo fmt --check, and no clippy. There are 5 files carrying tests and none of them run until someone runs them locally.
The failure mode this leaves open is a bad commit reaching users behind a green page: a tag fires release.yml and publish-crate.yml, and crates.io publication is irreversible per version. Nothing between the commit and that publish compiles a test.
anderix/lux has the model to copy: a rust job on push and PR against main that installs stable with rustfmt and clippy, uses Swatinem/rust-cache@v2, then runs cargo fmt --check, cargo clippy --all-targets -- -D warnings, and cargo test. lux's second conformance job is specific to its three-backend design and has no analogue here, so only the first job is wanted.
Sibling issues: excelano/xray#5, excelano/xled#15, and excelano/ved have the same gap. excelano/xensus#8 and excelano/xql#12 are the Go equivalents. xfiles is currently the only repo in the family with a test job on pull requests.
This repo has no
ci.yml. The workflows present aredeb.yml,publish-crate.yml, andrelease.yml, all tag-triggered, so a pull request gets no build, no test run, nocargo fmt --check, and no clippy. There are 5 files carrying tests and none of them run until someone runs them locally.The failure mode this leaves open is a bad commit reaching users behind a green page: a tag fires
release.ymlandpublish-crate.yml, and crates.io publication is irreversible per version. Nothing between the commit and that publish compiles a test.anderix/luxhas the model to copy: arustjob on push and PR againstmainthat installs stable with rustfmt and clippy, usesSwatinem/rust-cache@v2, then runscargo fmt --check,cargo clippy --all-targets -- -D warnings, andcargo test. lux's secondconformancejob is specific to its three-backend design and has no analogue here, so only the first job is wanted.Sibling issues: excelano/xray#5, excelano/xled#15, and excelano/ved have the same gap. excelano/xensus#8 and excelano/xql#12 are the Go equivalents.
xfilesis currently the only repo in the family with a test job on pull requests.