[BUG] config.InstallationHistory - [sql_server_version] column length

[jakemorgangit]

Component

Installer (GUI)

Performance Monitor Version

2.4.1

SQL Server Version

Microsoft SQL Server 2019 (RTM-CU16-GDR) (KB5014353) - 15.0.4236.7 (X64) May 29 2022 15:55:47 Copyright (C) 2019 Microsoft Corporation Enterprise Edition: Core-based Licensing (64-bit) on Windows Server 2019 Datacenter 10.0 (Build 17763: ) (Hypervisor)

Windows Version

Windows Server 2019

Describe the Bug

The [sql_server_version] column in [config].[installation_history] is currently limited to NVARCHAR(255).

However, some SQL Server version strings exceed this length, which results in the value being truncated or not inserted at all. This causes the dashboard to show no version history.

Example

In my case, the version string is ~267 characters, exceeding the current limit of 255:

Microsoft SQL Server 2019 (RTM-CU16-GDR) (KB5014353) - 15.0.4236.7 (X64) 
    May 29 2022 15:55:47 
    Copyright (C) 2019 Microsoft Corporation
    Enterprise Edition: Core-based Licensing (64-bit) on Windows Server 2019 Datacenter 10.0 <X64> (Build 17763: ) (Hypervisor)

Impact

Version information is not stored in [config].[installation_history]
Installer runs roll up scripts from v1
Dashboard thinks my version is out of date and required an update.

Steps to Reproduce

Install via PerformanceMonitor Installer, deployed against a SQL Server version with version info > 255 chars

Expected Behavior

Installer succeeds without errors, adding version info to [config].[installation_history]

Actual Behavior

Character limit is exceeded, meaning version info can't be written to [config].[installation_history]

Error Messages / Log Output

Screenshots

No response

Additional Context

No response

[erikdarlingdata]

@jakemorgangit ooh nice catch! Did you want to submit a fix for this?

[erikdarlingdata]

Fixed in PR #722. Widened sql_server_version and sql_server_edition to nvarchar(512). Upgrade script in 2.4.0-to-2.5.0 folder.