fix: reject standalone TreeLookup node at eval to match the reference interpreter#893
Open
mwaddip wants to merge 1 commit into
Open
fix: reject standalone TreeLookup node at eval to match the reference interpreter#893mwaddip wants to merge 1 commit into
mwaddip wants to merge 1 commit into
Conversation
… interpreter
The standalone `TreeLookup` node (opcode `AvlTreeGet`) has no eval override in
sigma-state: its `costKind` is `notSupportedError`, so the default `Value.eval`
raises ("Should be overriden"). The ErgoScript compiler emits an `AvlTree.get`
MethodCall rather than this node, so mainnet never reaches it — but sigma-rust
evaluated it directly via the AVL verifier, accepting a crafted tree that the
reference interpreter rejects. That is a consensus split on hand-crafted blocks
(the node serializes/deserializes fine; only eval diverges). Make eval error to
match the oracle; parsing and serialization are unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone
TreeLookupnode (opcodeAvlTreeGet) has no eval override in sigma-state — itscostKindisnotSupportedError, so the defaultValue.evalraises ("Should be overriden"). The ErgoScript compiler emits anAvlTree.getMethodCall, never this node, so mainnet never reaches it; but sigma-rust evaluated it directly via the AVL verifier, accepting a hand-crafted tree the reference interpreter rejects — a consensus split on crafted blocks (the node still serializes/deserializes fine; only eval diverged).This makes eval error to match the oracle; parsing and serialization are unchanged.
Found via SANTA conformance testing against the JVM oracle.