Waffle.Actions.Store.store does not include storage_dir config value (Waffle.Storage.Local)

[bumbus]

Environment

Erlang/OTP 23 [erts-11.1.5] [source] [64-bit] [smp:16:16] [ds:16:16:10] [async-threads:1] [hipe]
Elixir 1.12.3 (compiled with Erlang/OTP 22)

waffle 1.1.5
waffle_ecto 0.0.11

Issue

I am not sure if this is an actual bug or I misunderstand the role of storage_dir config.
Round about I have the following code:

config :waffle,
  storage: Waffle.Storage.Local,
  asset_host: "",
  storage_dir: "storage"

defmodule Storage.ProfileFile do
  use Waffle.Definition
  use Waffle.Ecto.Definition

  @versions [:original]

  def storage_dir(_version, {_file, profile}) do
    "profiles/#{profile.id}"
  end
end

  Storage.ProfileFile.store({
    %Plug.Upload{
      filename: file_name,
      path: meta.path
    },
    %{id: profile_file.profile_id}
  })

Expected behavior

I would expect the newly uploaded file is saved in storage/profiles/<SOME_ID>/FILENAME.EXT

Actual behavior

The newly uploaded file is actually saved in profiles/<SOME_ID>/FILENAME.EXT

[bumbus]

Ok the upload destination works with the following config:

config :waffle,
  storage: Waffle.Storage.Local,
  asset_host: "",
  # storage_dir: "storage"
  storage_dir_prefix: "storage"

But: Storage.ProfileFile.url({file_name, profile}) omits the storage_dir_prefix value.

[achempion]

Hey, This option is needed for local type of storage. By default, waffle stores your files in storage directory related to your project's root path. Depending on how you want to serve files, you may want to have a different directory structure. As an example, you may want to store files in "priv/waffle/public/users/:id/avatar.jpg" and have only "users/:id/avatar.jpg" part in url. In order to achieve this, you can define `storage_dir_prefix` in global config as "priv/waffle/private" to make sure by default your files are private (considering you configured access restrictions when serving files from that directory) and for public files you just define storage_dir_prefix function in each public uploader with a value of "priv/waffle/public" to override the default setting. That way you can achieve elaborate directory structure and not expose that structure in urls.

[Faheemvc]

store/1 in Waffle does not currently support specifying a version directly. There doesn’t seem to be an option to pass a version to store only a specific version defined in the definition module.

Is there an alternative or recommended approach to store a specific version without storing all versions? For example, some way to target a particular version defined in __versions__/0 while still using store?

[achempion]

Hi @Faheemvc, you can return :skip from the transform function based on a condition (second argument is a scope which you can base your condition on)