From 082285faab7cc9bbe597a25ab0cb7195755df6b2 Mon Sep 17 00:00:00 2001 From: Shahzaib Ibrahim Date: Mon, 19 Jan 2026 11:18:52 +0100 Subject: [PATCH 1/2] Use OfFloat Point values to create precise highlight brackets Because of rounding errors the bracket selection highlight is often inconsistent. Making use of residual values provides precise rectangle values and highlight is consistent across all zooms --- .../jface/text/source/MatchingCharacterPainter.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java index f63a54c6c1d6..4fb4c881a66f 100644 --- a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java +++ b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java @@ -262,12 +262,13 @@ private void draw(final GC gc, final int offset) { // determine the character width separately, because the getTextBounds above // will also include any in-line annotations (e.g. codemining annotations) in the width final String matchingCharacter= fTextWidget.getText(offset, offset); - final int width= gc.textExtent(matchingCharacter).x; - + Point characterBounds= gc.textExtent(matchingCharacter); final int height= fTextWidget.getCaret().getSize().y; + characterBounds.y= height - 1; + Rectangle hightlightingArea= Rectangle.of(new Point(bounds.x, bounds.y + bounds.height - height), characterBounds); // draw box around line segment - gc.drawRectangle(bounds.x, bounds.y + bounds.height - height, width, height - 1); + gc.drawRectangle(hightlightingArea); } else { fTextWidget.redrawRange(offset, 1, true); } From 5be054214ae381353e2cdd4e31820673e19c18c9 Mon Sep 17 00:00:00 2001 From: Shahzaib Ibrahim Date: Thu, 22 Jan 2026 15:51:19 +0100 Subject: [PATCH 2/2] Better fix --- .../jface/text/source/MatchingCharacterPainter.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java index 4fb4c881a66f..85a2b460d5bd 100644 --- a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java +++ b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/MatchingCharacterPainter.java @@ -257,15 +257,11 @@ private void draw(final GC gc, final int offset) { if (gc != null) { gc.setForeground(fColor); - final Rectangle bounds= fTextWidget.getTextBounds(offset, offset); + Point offsetLocation= fTextWidget.getLocationAtOffset(offset); - // determine the character width separately, because the getTextBounds above - // will also include any in-line annotations (e.g. codemining annotations) in the width final String matchingCharacter= fTextWidget.getText(offset, offset); Point characterBounds= gc.textExtent(matchingCharacter); - final int height= fTextWidget.getCaret().getSize().y; - characterBounds.y= height - 1; - Rectangle hightlightingArea= Rectangle.of(new Point(bounds.x, bounds.y + bounds.height - height), characterBounds); + Rectangle hightlightingArea= Rectangle.of(offsetLocation, characterBounds); // draw box around line segment gc.drawRectangle(hightlightingArea);