Skip to content

Commit 8efbfcc

Browse files
committed
test(profile): remove implicit root identity assumption
1 parent 6540b99 commit 8efbfcc

1 file changed

Lines changed: 4 additions & 26 deletions

File tree

‎src/test/java/io/github/easy4j/hermes/HermesOkHttpClientTest.java‎

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -34,40 +34,18 @@
3434
class HermesOkHttpClientTest {
3535

3636
@Test
37-
void shouldRouteManagedProfilesThroughOneSharedTransport() {
38-
AtomicReference<String> requestedPath = new AtomicReference<>();
39-
OkHttpClient external = new OkHttpClient.Builder()
40-
.addInterceptor(chain -> {
41-
requestedPath.set(chain.request().url().encodedPath());
42-
return new Response.Builder()
43-
.request(chain.request())
44-
.protocol(Protocol.HTTP_1_1)
45-
.code(200)
46-
.message("OK")
47-
.body(ResponseBody.create(
48-
"{\"id\":\"response-1\",\"choices\":[]}",
49-
MediaType.get("application/json")))
50-
.build();
51-
})
52-
.build();
37+
void shouldNotDeriveNamedProfileFromUncredentialedExternalTransport() {
38+
OkHttpClient external = new OkHttpClient.Builder().build();
5339
HermesHttpClientConfig httpConfig = new HermesHttpClientConfig();
5440
httpConfig.markUnsafeBaseUrlOverriddenForTest(true);
5541
httpConfig.setBaseUrl("http://127.0.0.1:8642/");
5642
HermesCliConfig cliConfig = new HermesCliConfig();
5743
cliConfig.setEnabled(false);
5844

5945
try (HermesClient client = new HermesClient(httpConfig, cliConfig, new ObjectMapper(), external)) {
60-
HermesClient sales = client.forProfile("sales");
61-
assertSame(sales, client.forProfile("sales"));
62-
assertSame(external, sales.getOkHttpClient());
63-
assertFalse(sales.isCliEnabled());
64-
sales.chatCompletion(new ChatRequest());
65-
assertEquals("/p/sales/v1/chat/completions", requestedPath.get());
46+
assertSame(external, client.getOkHttpClient());
47+
assertThrows(IllegalStateException.class, () -> client.forProfile("sales"));
6648
assertThrows(IllegalArgumentException.class, () -> client.forProfile("../sales"));
67-
assertThrows(IllegalStateException.class, () -> sales.forProfile("care"));
68-
69-
sales.close();
70-
assertSame(sales, client.forProfile("sales"));
7149
} finally {
7250
HermesOkHttpClientFactory.shutdown(external);
7351
}

0 commit comments

Comments
 (0)