Skip to content

Use per-fraction reference doses in quality indicators#904

Closed
acsevillam wants to merge 1 commit into
e0404:dev_varRBErobOptfrom
acsevillam:pr/quality-indicators-per-fraction
Closed

Use per-fraction reference doses in quality indicators#904
acsevillam wants to merge 1 commit into
e0404:dev_varRBErobOptfrom
acsevillam:pr/quality-indicators-per-fraction

Conversation

@acsevillam
Copy link
Copy Markdown

@acsevillam acsevillam commented Apr 30, 2026

Bug description

Quality indicators mixed per-fraction dose cubes with total prescription/objective doses in some analysis paths.

Approach

This PR keeps canonical quality indicators in per-fraction dose units and adds explicit conversion helpers for display/evaluation in total dose when requested.

Open Questions and/or Concerns

  • Confirm the per-fraction convention is the desired canonical representation for plan analysis outputs.

References

None.

@wahln
Copy link
Copy Markdown
Contributor

wahln commented May 5, 2026

This is nice and makes it more consistent. The per fraction thing is anyway something that is very strongly debated among us, so the conversion function for the modes is also good.

I just realized you opened the PR onto dev_varRBErobOpt - could you rebase/reopen onto dev? dev_varRBErobOpt was merged into dev quite some time ago. If yes, please close this PR when the new one is reopened.

@acsevillam
Copy link
Copy Markdown
Author

Closing this PR in favor of #909.

The new PR preserves the original intent of #904: quality indicators are kept canonical in dose per fraction, with explicit conversion applied only for evaluation and display. PR #909 adapts this behavior to the current dev codebase.

@acsevillam acsevillam closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants