Fixes GriddedScenario to allow single grid point (i.e., only scenario model) for a certain error type#898
Open
wahln wants to merge 3 commits into
Open
Fixes GriddedScenario to allow single grid point (i.e., only scenario model) for a certain error type#898wahln wants to merge 3 commits into
wahln wants to merge 3 commits into
Conversation
…nts is 1, which will reduce to the nominal scenario in this dimension. Also provides corresponding tests for this case
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #898 +/- ##
==========================================
+ Coverage 54.80% 54.86% +0.05%
==========================================
Files 320 320
Lines 20548 20552 +4
==========================================
+ Hits 11261 11275 +14
+ Misses 9287 9277 -10 ☔ View full report in Codecov by Sentry. |
Test Results 3 files ±0 3 suites ±0 29m 53s ⏱️ - 1m 59s For more details on these failures, see this check. Results for commit d57d645. ± Comparison against base commit adf48b0. ♻️ This comment has been updated with latest results. |
…ng to code style guidelines
|
This PR was automatically marked as stale it has been open 30 days with no activity. Please review/update/merge this PR. |
github-actions
Bot
added
stale
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the handling of grid points and scenario combinations in the gridded scenario classes, especially for worst-case scenarios. It allows to set the number of grid points to 1, which then reduces to only the nominal scenario for the corresponding error type. Additionally, new tests are added to verify the correct behavior of grid point assignments.
Enhancements to grid point handling and validation:
numOfSetupGridPointsandnumOfRangeGridPointsinmatRad_WorstCaseScenariosto enforce that only 1 or 3 are valid values, with clear error messages for invalid assignments.matRad_GriddedScenariosAbstractandmatRad_WorstCaseScenariosto use MATLAB's property syntax without semicolons, improving style consistency. [1] [2]Improvements to scenario grid generation logic:
matRad_GriddedScenariosAbstractto explicitly handle the case where only one grid point is used (assigning zero shift and using the nominal scenario properties), and removed commented-out legacy code. [1] [2]Testing improvements:
test_worstCaseScenarioGridPoints, to verify correct scenario counts and to ensure that invalid grid point assignments throw appropriate errors.General code cleanup and documentation: