herbe doesn't close itself (sometimes)

[faustri]

I'm on alpine linux, using dwm in floating mode, herbe as standalone, and this script to put herbe in the background 'setsid nohup $@ &> /dev/null &'. Can't reproduce it at will, but often notice notification has stopped and have to find the herbe notification to click it away manually.

Anyone know what the issue could be?

I'm on OpenBSD 6.9 and I also faced this issue a few times when using nohup

[N-R-K]

Possible suspect is the fact that herbe is calling Xlib functions inside the signal handler.

herbe/herbe.c

Lines 73 to 80 in dec89e4

	void expire(int sig)
	{
	XEvent event;
	event.type = ButtonPress;
	event.xbutton.button = (sig == SIGUSR2) ? (ACTION_BUTTON) : (DISMISS_BUTTON);
	XSendEvent(display, window, 0, 0, &event);
	XFlush(display);
	}

You can only call functions which are async-signal-safe from inside a signal handler, see man 7 signal-safety.

[N-R-K]

@faustri @alreadyburnt Try out #40 and see if that solves the issue or not.

@N-R-K thanks for the PR. I don't know exactly when it happens but for now it seems to work fine. I'll come back here if I experience this issue again.