[Bug] VaultPanel tab labels bypass i18n due to variable shadowing

[collinsezedike]

Description

VaultPanel's tab switcher renders "Deposit"/"Withdraw" in English only, regardless of the active locale, because of a variable-shadowing bug: t is destructured from useTranslation() for the whole component, then re-bound as the loop variable in (["deposit", "withdraw"] as Tab[]).map((t) => ...). Inside that map, t.charAt(0).toUpperCase() + t.slice(1) capitalizes the raw tab id string instead of calling the translation function, since t no longer refers to the translator at that point.

Steps to Reproduce

1. Switch the app's locale to French.
2. Open the vault panel while a wallet is connected.
3. Look at the tab switcher above the deposit/withdraw form.

Expected Behavior

Tab labels should read the French translations (the rest of the component consistently uses t("vaultPanel.xxx") for every other label).

Actual Behavior

Tab labels always show the raw capitalized English strings "Deposit"/"Withdraw", never translated, in any locale.

Environment

Field	Value
Network	N/A
Wallet	N/A
Protocol affected	Frontend
Browser (if frontend)	Any
Node.js version	N/A
pnpm version	N/A

Transaction Details (if on-chain)

N/A, frontend-only bug.

Logs / Screenshots

N/A, visually confirmed by reading apps/web/src/components/dashboard/VaultPanel.tsx (the tab switcher block, around where useTranslation()'s t is shadowed by the .map((t) => ...) parameter over ["deposit", "withdraw"]).

Possible Cause / Fix

Rename the map callback's parameter (e.g. tabId) so it stops shadowing the translator, and call t("vaultPanel.deposit")/t("vaultPanel.withdraw") instead of capitalizing the raw id. Check apps/web/messages/en.json/fr.json for whether matching keys already exist under vaultPanel.* before adding new ones.

[drips-wave]

Congratulations, @badmusnadrohabidemi-blip! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on July 30, 2026.

🧑‍💻 @badmusnadrohabidemi-blip: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊