From 679fa6c9681215c9c9bd481b960cbd01c654fc2a Mon Sep 17 00:00:00 2001
From: StevSoested <149892642+StevSoested@users.noreply.github.com>
Date: Fri, 6 Nov 2026 17:11:57 +0100
Subject: [PATCH] Refactor resolver callback to use mutable captureRelease
 HttpClient on its loop after a DNS lookup

Updated lambda function to use mutable capture for 'thisPtr' and added comments for clarity.
---
 lib/src/HttpClientImpl.cc | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/lib/src/HttpClientImpl.cc b/lib/src/HttpClientImpl.cc
index 0790c6ca13..9f08fc7d28 100644
--- a/lib/src/HttpClientImpl.cc
+++ b/lib/src/HttpClientImpl.cc
@@ -485,8 +485,13 @@ void HttpClientImpl::sendRequestInLoop(const drogon::HttpRequestPtr &req,
         }
         auto thisPtr = shared_from_this();
         resolverPtr_->resolve(
-            domain_, [thisPtr](const trantor::InetAddress &addr) {
-                thisPtr->loop_->runInLoop([thisPtr, addr]() {
+            domain_, [thisPtr](const trantor::InetAddress &addr) mutable {
+                // The resolver may call back on a thread of its own and
+                // destroy this callback there. Move the client to its loop,
+                // so that its last reference is never dropped elsewhere:
+                // ~HttpClientImpl() would then use a loop that may be gone.
+                auto loop = thisPtr->loop_;
+                loop->runInLoop([thisPtr = std::move(thisPtr), addr]() {
                     // Retrieve port from old serverAddr_
                     auto port = thisPtr->serverAddr_.portNetEndian();
                     thisPtr->serverAddr_ = addr;