Skip to content

Commit 3a883fc

Browse files
rolfbjarneCopilot
andcommitted
[dotnet] Sign net11.0 workload msbuild task DLLs
The verify signed msi content step on net11.0 started failing because three task assemblies in tools/msbuild/net11.0 were still covered by the older Skip entries that were added for the pre-signed net10.0 copies. Scope the Skip entries to the net10.0 paths and sign the net11.0 copies as first-party so they do not remain unsigned in the MSI payload. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent f836668 commit 3a883fc

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

dotnet/Workloads/SignList.xml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,12 @@
3535
<Skip Include="Build\System.Text.Json.dll" />
3636
<Skip Include="Build\System.Threading.Tasks.Dataflow.dll" />
3737
<Skip Include="Build\System.Threading.Tasks.Extensions.dll" />
38-
<!-- net10.0 msbuild tools content -->
39-
<Skip Include="AssemblyStripper.dll" />
38+
<!-- Pre-signed msbuild tools content -->
39+
<Skip Include="tools\msbuild\net10.0\AssemblyStripper.dll" />
4040
<Skip Include="BouncyCastle.Cryptography.dll" />
41-
<Skip Include="ILLink.Tasks.dll" />
41+
<Skip Include="tools\msbuild\net10.0\ILLink.Tasks.dll" />
4242
<Skip Include="Microsoft.Win32.SystemEvents.dll" />
43-
<Skip Include="MonoTargetsTasks.dll" />
43+
<Skip Include="tools\msbuild\net10.0\MonoTargetsTasks.dll" />
4444
<Skip Include="MQTTnet.dll" />
4545
<Skip Include="System.CodeDom.dll" />
4646
<Skip Include="System.ComponentModel.Composition.dll" />
@@ -138,6 +138,10 @@
138138
<FirstParty Include="Broker.resources.dll" />
139139
<!-- Build.zip -->
140140
<FirstParty Include="Build.dll" />
141+
<!-- The net11.0 SDK packs ship these task assemblies unsigned, so we sign them here. -->
142+
<FirstParty Include="tools\msbuild\net11.0\AssemblyStripper.dll" />
143+
<FirstParty Include="tools\msbuild\net11.0\ILLink.Tasks.dll" />
144+
<FirstParty Include="tools\msbuild\net11.0\MonoTargetsTasks.dll" />
141145
<FirstParty Include="Microsoft.Build*.dll" />
142146
<FirstParty Include="Microsoft.NET.StringTools.dll" />
143147
<FirstParty Include="System.IO.Abstractions.dll" />

0 commit comments

Comments
 (0)