Issue with compiling "cannot use keyword 'false' as enumeration constant"

[Mosblinker]

I am trying to compile it with the latest version of GBA DevKitArm and I keep getting this error when compiling:

In file included from ./include/m_fixed.h:38,
                 from ./include/p_pspr.h:40,
                 from ./include/d_player.h:44,
                 from ./include/doomstat.h:43,
                 from ./source/am_map.c:3:
./include/doomtype.h:48:15: error: cannot use keyword 'false' as enumeration constant
   48 | typedef enum {false, true} boolean;
      |               ^~~~~
./include/doomtype.h:48:15: note: 'false' is a keyword with '-std=c23' onwards
make[1]: *** [/opt/devkitpro/devkitARM/base_rules:40: am_map.o] Error 1
make: *** [Makefile:132: build] Error 2

[Kippykip]

Not another one... 😭
I don't know why gcc/devkitARM keep constantly breaking things, makes it so tricky to maintain.

[FrenkelS]

That's odd, -std=gnu11 is already in the Makefile. That should have fixed it.

[goombobross]

Not another one... 😭 I don't know why gcc/devkitARM keep constantly breaking things, makes it so tricky to maintain.

hey, since this is the only place i can contact you, I have restored the depth fog effect in gbadoom with like 1 fps penalty, check your discord

[Kippykip]

Not another one... 😭 I don't know why gcc/devkitARM keep constantly breaking things, makes it so tricky to maintain.

hey, since this is the only place i can contact you, I have restored the depth fog effect in gbadoom with like 1 fps penalty, check your discord

Oh cool! Have you got a PR?
I think you might need re-add me though on discord as I've had another account for a year.
kippykip.com is the handle

That's odd, -std=gnu11 is already in the Makefile. That should have fixed it.

Might look into this again this year, my GBADoom and devkitarm are ancient now but I got a new Arbernic handheld I want to try and use for testing. So getting back into helping this project again would be a fun thing to resume on the side.

[goombobross]

Not another one... 😭 I don't know why gcc/devkitARM keep constantly breaking things, makes it so tricky to maintain.

hey, since this is the only place i can contact you, I have restored the depth fog effect in gbadoom with like 1 fps penalty, check your discord

Oh cool! Have you got a PR? I think you might need re-add me though on discord as I've had another account for a year. kippykip.com is the handle

That's odd, -std=gnu11 is already in the Makefile. That should have fixed it.

Might look into this again this year, my GBADoom and devkitarm are ancient now but I got a new Arbernic handheld I want to try and use for testing. So getting back into helping this project again would be a fun thing to resume on the side.

https://github.com/goombobross/doom-gba-depth-fog this is my fork in its own repository. Feel free to try to optimize if possible! remeber, you need python for the iwram script and make the build with make IWRAM_MIN_GAP=2048 oh and feel free to fork it or try to merge into your build if you want!

[cricri-pingouin]

Back on topic, I get the same error:

C:/devkitPro/Projects/GBADoom/include/doomtype.h:48:15: error: cannot use keyword 'false' as enumeration constant
48 | typedef enum {false, true} boolean;
| ^~~~~
C:/devkitPro/Projects/GBADoom/include/doomtype.h:48:15: note: 'false' is a keyword with '-std=c23' onwards

Also, step 3 of instructions is incorrect:
Open C:\DevKitPro\Projects\GBADoom\source\doom_iwad.h in text editor or code editor of your choice.

Should be doom_iwad.c

And to be pedantic, step 4 shouldn't be "Change the first line to" since the first 2 lines are setting switches and including the header, step 4 should say to uncomment whichever c file for the wad and make sure all others include .c are commented.

Also step 5 doesn't need to enter the make command since you already pass make.sh which already runs it. I had to remove it and type make manually so that I could see the error though.

I've proposed some changes and opened a pull request.