Skip to content

Commit ffc478f

Browse files
donislawdevclaude
andcommitted
packaging: the WinGet sentences say only what was measured, and the command line is now measured too
An outside review of #144 said two sentences claimed more than was measured: the command line's upgrade warning was inferred from the window, and the README presented an issue with one reproduction as true of every package. The command line is now measured. On Windows 11 in user scope, with a tfg run held in progress, the upgrade failed with "Access is denied" and left only the program and the notices in the folder, and ran through once the run ended - the same as the window. The window measurement was repeated there with the same result, so the description now says what happens rather than a general rule. The PATH entry left after an uninstall was reproduced in user scope on Windows 11 as well as in machine scope on Windows Server 2025, for both packages, with WinGet 1.29.380. The README says that, and describes microsoft/winget-cli#6160 as a report of the same for another package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 04011b7 commit ffc478f

2 files changed

Lines changed: 22 additions & 15 deletions

File tree

‎.github/scripts/build_packages.py‎

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,21 +85,24 @@
8585
def how_to_start(package, feed):
8686
"""The paragraph that differs by feed: what the package gives and how to start it.
8787
88-
The WinGet sentences about upgrading are measured, not assumed: on Windows
89-
Server 2025 with WinGet 1.29.380 on 2026-09-25, upgrading the window while
90-
it was open failed with "Access is denied" and left the package folder half
91-
removed until the upgrade ran again with the window closed. A portable
92-
package can carry no script to warn at that moment, so the description is
93-
the only place a person can read it first.
88+
The WinGet sentences about upgrading are measured, not assumed, with WinGet
89+
1.29.380 on 2026-09-25: on Windows Server 2025 in machine scope and on
90+
Windows 11 in user scope, upgrading the window while it was open failed
91+
with "Access is denied" and left the package folder half removed until the
92+
upgrade ran again with the window closed. On Windows 11 the command line
93+
did the same while a tfg run was in progress. A portable package can carry
94+
no script to warn at that moment, so the description is the only place a
95+
person can read it first.
9496
"""
9597
other = next(p for p in PACKAGES if p is not package)
9698
other_id = other.winget_id if feed == "winget" else other.choco_id
9799
if package.kind == "cli":
98100
text = ("This package is the command line, for scripts and pipelines. The desktop "
99101
"window is the package %s. Type tfg help to see the commands." % other_id)
100102
if feed == "winget":
101-
text += (" Upgrade it when no tfg run is in progress. WinGet cannot replace a "
102-
"program while it runs.")
103+
text += (" Upgrade it when no tfg run is in progress. WinGet cannot replace "
104+
"tfg while it runs, so it stops half way, and the package works again "
105+
"once the upgrade runs with no run in progress.")
103106
return text
104107
if feed == "winget":
105108
return ("This package is the desktop window. The command line is the package %s. "

‎packaging/README.md‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,12 @@ the real file. With it, WinGet makes no link and puts the package's folder on
3636
depends on the machine - a link where symbolic links are allowed, the folder on
3737
`PATH` where they are not. WinGet adds no Start menu shortcut for a portable
3838
package, and the window's description says so. One cost of the field is not
39-
ours to fix: WinGet leaves the package's folder on `PATH` after an uninstall -
39+
ours to fix. WinGet 1.29.380 left the package's folder on `PATH` after an
40+
uninstall, for both of these packages, in machine scope on Windows Server 2025
41+
and in user scope on Windows 11 - measured on 2026-09-25, the entry stays and
42+
points at a folder that no longer exists.
4043
[microsoft/winget-cli#6160](https://github.com/microsoft/winget-cli/issues/6160),
41-
open, and true of every package that sets it. Measured here with WinGet
42-
1.29.380: the entry stays, pointing at a folder that no longer exists.
44+
open, reports the same for another package that sets the field.
4345

4446
**Chocolatey.** The package downloads the release archive rather than carrying
4547
it, so it holds no binaries and owes no `VERIFICATION.txt`, and the archive is the
@@ -56,8 +58,9 @@ and an icon on a branch would keep changing under an approved package.
5658

5759
**Neither package ends a running program** - a run in progress may be halfway
5860
through a set of files, and cutting it would leave files with no manifest to say
59-
what they are. What each feed does instead was measured on Windows Server 2025
60-
on 2026-09-25, with the window open:
61+
what they are. What each feed does instead was measured on 2026-09-25, with the
62+
program running - Chocolatey on Windows Server 2025, WinGet there in machine
63+
scope and on Windows 11 in user scope:
6164

6265
- **Chocolatey goes ahead**, an upgrade and an uninstall alike, and reports
6366
success. It moves the package folder aside to `lib-bkp`, and the running copy
@@ -67,8 +70,9 @@ on 2026-09-25, with the window open:
6770
names the folder to delete once the program is closed.
6871
- **WinGet stops half way.** An upgrade fails with "Access is denied" on the
6972
program, having already deleted some of the other files, and the package works
70-
again once the upgrade runs with the window closed. A portable package carries
71-
no script, so the description is where this is said.
73+
again once the upgrade runs with the program closed. Measured for the window
74+
and, on Windows 11, for the command line with a run in progress. A portable
75+
package carries no script, so the description is where this is said.
7276

7377
## Submitting
7478

0 commit comments

Comments
 (0)