Repository navigation
Commit d307d42
guard: a build that cannot run is not a build that refused
TestABuildWithoutTheBuildTagsRefusesAndSaysWhy shells out to the compiler and
treats any error as the refusal it is looking for. A missing compiler arrives
the same way, so on a machine with no Go it reported that the refusal "does
not name build tags" - with the message empty, blaming the refusal rather
than the environment.
Measured on 2026-09-06: that is exactly what it did in the container
tools/linux-check.py uses, which has no Go in it by design. It was the only
test of the whole suite to fail there.
This one cannot use the "an error means skip" shape the other ten callers of
the toolchain use, because here an error is the answer. So it asks
exec.LookPath first, the same idiom and for the same reason as
TestABuildWithNoWindowInItSaysSoAndKeepsStandardOutputEmpty.
Still passes where a compiler exists, and its existing mutation still turns it
red, so the skip did not quietly make it a no-op.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent fe2fbdb commit d307d42
1 file changed
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
150 | 166 | | |
151 | 167 | | |
152 | 168 | | |
| |||
0 commit comments