Skip to content

Dialog._dialogStack holds reference to removed node #189

Description

@xmedeko

Dialog._dialogStack items focus property is not cleared, so the 0th item may hold a reference to an item removed from DOM i.e. kind of a leak. I suggest one of the following solutions:

  • Stop using previous ds item and just set previous focus to the current ds item.
  • The focus in the previous ds item is removed on hide().
  • The focus is held by a weak reference.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions