From 01e9d6bf08afa7aa7187d5ac4112fdbea6ce2788 Mon Sep 17 00:00:00 2001 From: Vincent Potucek Date: Wed, 15 Oct 2025 14:39:50 +0200 Subject: [PATCH] Add `FindVirtualThreadOpportunities` All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck, com.diffplug.spotless.openrewrite.SanityCheck, com.diffplug.spotless.openrewrite.SanityCheck, com.diffplug.spotless.openrewrite.SanityCheck, com.diffplug.spotless.openrewrite.SanityCheck, com.diffplug.spotless.openrewrite.SanityCheck Changes have been made to lib/src/main/java/com/diffplug/spotless/ProcessRunner.java by: com.diffplug.spotless.openrewrite.SanityCheck org.openrewrite.java.migrate.lang.FindVirtualThreadOpportunities org.openrewrite.java.migrate.lang.FindNonVirtualExecutors org.openrewrite.java.search.FindMethods: {methodPattern=java.util.concurrent.Executors#newSingleThreadExecutor(..)} Changes have been made to testlib/src/test/java/com/diffplug/spotless/GitPrePushHookInstallerTest.java by: com.diffplug.spotless.openrewrite.SanityCheck org.openrewrite.java.migrate.lang.FindVirtualThreadOpportunities org.openrewrite.java.search.FindMethods: {methodPattern=java.lang.Thread#(..)} Please review and commit the results. Estimate time saved: 10m --- lib/src/main/java/com/diffplug/spotless/ProcessRunner.java | 4 ++-- rewrite.yml | 3 +++ .../com/diffplug/spotless/GitPrePushHookInstallerTest.java | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/src/main/java/com/diffplug/spotless/ProcessRunner.java b/lib/src/main/java/com/diffplug/spotless/ProcessRunner.java index 05f5880129..0457390462 100644 --- a/lib/src/main/java/com/diffplug/spotless/ProcessRunner.java +++ b/lib/src/main/java/com/diffplug/spotless/ProcessRunner.java @@ -48,8 +48,8 @@ * calls to an external process. */ public class ProcessRunner implements AutoCloseable { - private final ExecutorService threadStdOut = Executors.newSingleThreadExecutor(); - private final ExecutorService threadStdErr = Executors.newSingleThreadExecutor(); + private final ExecutorService threadStdOut = /*~~>*/Executors.newSingleThreadExecutor(); + private final ExecutorService threadStdErr = /*~~>*/Executors.newSingleThreadExecutor(); private final ByteArrayOutputStream bufStdOut; private final ByteArrayOutputStream bufStdErr; diff --git a/rewrite.yml b/rewrite.yml index a7f4e4654d..33a3e17aec 100644 --- a/rewrite.yml +++ b/rewrite.yml @@ -17,6 +17,9 @@ recipeList: - org.openrewrite.java.format.NormalizeLineBreaks - org.openrewrite.java.format.RemoveTrailingWhitespace - org.openrewrite.java.migrate.UpgradeToJava17 + - org.openrewrite.java.migrate.lang.FindVirtualThreadOpportunities + - org.openrewrite.java.migrate.lang.StringRulesRecipes + - org.openrewrite.java.migrate.util.JavaLangAPIs - org.openrewrite.java.migrate.util.JavaUtilAPIs - org.openrewrite.java.migrate.util.MigrateInflaterDeflaterToClose - org.openrewrite.java.migrate.util.ReplaceStreamCollectWithToList diff --git a/testlib/src/test/java/com/diffplug/spotless/GitPrePushHookInstallerTest.java b/testlib/src/test/java/com/diffplug/spotless/GitPrePushHookInstallerTest.java index a5be4ea43c..6b42c43f6c 100644 --- a/testlib/src/test/java/com/diffplug/spotless/GitPrePushHookInstallerTest.java +++ b/testlib/src/test/java/com/diffplug/spotless/GitPrePushHookInstallerTest.java @@ -380,7 +380,7 @@ private String mavenHookContent(String resourcePath, ExecutorType executorType) private void parallelRun(ThrowableRun runnable) { IntStream.range(0, 5) - .mapToObj(i -> new Thread(() -> { + .mapToObj(i -> /*~~>*/new Thread(() -> { try { runnable.run(); } catch (Exception e) {